Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1889] Run R/Python tests. #1890

Closed

Conversation

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Jan 25, 2018

Resolves #1889.

Let's see if this does it...

Frank Austin Nothaft
Resolves #1889.
mvn -U \
-P python,r \
package \
-DskipTests \
test \

This comment has been minimized.

@heuermh

heuermh Jan 25, 2018
Member

I seem to recall skipping python tests was intentional?

Sorry, this was the thread I was mis-remembering...
https://gitter.im/bigdatagenomics/adam?at=5a01ec9d976e63937e3b5202

... which refers to #1800

This comment has been minimized.

@akmorrow13

akmorrow13 Jan 25, 2018
Contributor

Why would we want to skip python tests? This would result in merging broken code.

This comment has been minimized.

@heuermh

heuermh Jan 25, 2018
Member

I dunno, git blame points to commit 7e92b9d and before that commit 640c44b and before that commit c34a440, so it's always been that way

This comment has been minimized.

@fnothaft

fnothaft Jan 26, 2018
Author Member

Nope, not intentional, just a goof on my end.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jan 25, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2602/

Build result: FAILURE

[...truncated 7 lines...] > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1890/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains 307fec4 # timeout=10Checking out Revision 307fec4 (origin/pr/1890/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 307fec48d25a927beb2179d3c7dea0052f139db1First time build. Skipping changelog.Triggering ADAM-prb ? 2.7.3,2.11,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.10,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.1,centosADAM-prb ? 2.7.3,2.11,2.2.1,centos completed with result FAILUREADAM-prb ? 2.6.2,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.11,2.2.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@coveralls
Copy link

@coveralls coveralls commented Jan 25, 2018

Coverage Status

Coverage remained the same at 82.707% when pulling c696772 on fnothaft:issues/1889-python-r-tests into adff336 on bigdatagenomics:master.

@akmorrow13
Copy link
Contributor

@akmorrow13 akmorrow13 commented Jan 25, 2018

@fnothaft do you have residual code for python ReferenceRegion that wasn't merged or should we write this from scratch?

@fnothaft
Copy link
Member Author

@fnothaft fnothaft commented Jan 26, 2018

do you have residual code for python ReferenceRegion that wasn't merged or should we write this from scratch?

Yeah, let me find it. I think it is on my Berkeley laptop.

@akmorrow13
Copy link
Contributor

@akmorrow13 akmorrow13 commented Feb 2, 2018

Closing in favor of #1892

@akmorrow13 akmorrow13 closed this Feb 2, 2018
@heuermh heuermh added this to the 0.24.0 milestone Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants