New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1900] Close stream after reading VCF header. #1901

Merged
merged 1 commit into from Feb 3, 2018

Conversation

4 participants
@fnothaft
Member

fnothaft commented Feb 3, 2018

Resolves #1900.

@fnothaft fnothaft added the bug label Feb 3, 2018

@fnothaft fnothaft added this to the 0.24.0 milestone Feb 3, 2018

@fnothaft fnothaft requested a review from heuermh Feb 3, 2018

@coveralls

This comment has been minimized.

coveralls commented Feb 3, 2018

Coverage Status

Coverage decreased (-0.009%) to 82.556% when pulling 25002b5 on fnothaft:issues/1900-close-vcf-header-is into cc7e447 on bigdatagenomics:master.

3 similar comments
@coveralls

This comment has been minimized.

coveralls commented Feb 3, 2018

Coverage Status

Coverage decreased (-0.009%) to 82.556% when pulling 25002b5 on fnothaft:issues/1900-close-vcf-header-is into cc7e447 on bigdatagenomics:master.

@coveralls

This comment has been minimized.

coveralls commented Feb 3, 2018

Coverage Status

Coverage decreased (-0.009%) to 82.556% when pulling 25002b5 on fnothaft:issues/1900-close-vcf-header-is into cc7e447 on bigdatagenomics:master.

@coveralls

This comment has been minimized.

coveralls commented Feb 3, 2018

Coverage Status

Coverage decreased (-0.009%) to 82.556% when pulling 25002b5 on fnothaft:issues/1900-close-vcf-header-is into cc7e447 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 3, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2639/
Test PASSed.

@heuermh

heuermh approved these changes Feb 3, 2018

@heuermh

This comment has been minimized.

Member

heuermh commented Feb 3, 2018

Progress towards #1719.

@heuermh heuermh merged commit aa43a56 into bigdatagenomics:master Feb 3, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Member

heuermh commented Feb 3, 2018

Thank you, @fnothaft

@heuermh heuermh added this to Completed in Release 0.24.0 Feb 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment