New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1882] Return true if ADAM_HOME is set, not exit 0. #1903

Closed
wants to merge 1 commit into
base: master
from

Conversation

4 participants
@heuermh
Member

heuermh commented Feb 5, 2018

Fixes #1882. Thank you to @pbashyal-nmdp for the patch.

@coveralls

This comment has been minimized.

coveralls commented Feb 5, 2018

Coverage Status

Coverage remained the same at 82.556% when pulling eba13b0 on heuermh:issue-1882 into aa43a56 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 5, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2643/
Test PASSed.

@fnothaft

This comment has been minimized.

Member

fnothaft commented Feb 5, 2018

@heuermh you should be able to apply the patch as @pbashyal-nmdp.

@heuermh

This comment has been minimized.

Member

heuermh commented Feb 5, 2018

@heuermh you should be able to apply the patch as @pbashyal-nmdp.

Teach me?

@fnothaft

This comment has been minimized.

Member

fnothaft commented Feb 6, 2018

See over at #1905. I put the patch in a file named patch-1882. Then, I did:

git apply patch-1882
git commit -a --author="authorname <author@email.com>"
@heuermh

This comment has been minimized.

Member

heuermh commented Feb 6, 2018

Closed in favor of #1905.

@heuermh heuermh closed this Feb 6, 2018

@heuermh heuermh deleted the heuermh:issue-1882 branch Feb 6, 2018

@heuermh heuermh added this to the 0.24.0 milestone Feb 6, 2018

@heuermh heuermh added this to Completed in Release 0.24.0 Feb 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment