New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1806] Add toVariants conversion from GenotypeRDD. #1904

Merged
merged 1 commit into from Mar 1, 2018

Conversation

4 participants
@fnothaft
Member

fnothaft commented Feb 5, 2018

Resolves #1806.

@fnothaft fnothaft added this to the 0.24.0 milestone Feb 5, 2018

@fnothaft fnothaft requested a review from heuermh Feb 5, 2018

@fnothaft

This comment has been minimized.

Member

fnothaft commented Feb 5, 2018

Just realized, this needs to propagate through to R/Python as well.

@heuermh

This comment has been minimized.

Member

heuermh commented Feb 5, 2018

Just realized, this needs to propagate through to R/Python as well.

Yep, at least we haven't spread ourselves too thin. ;)

@coveralls

This comment has been minimized.

coveralls commented Feb 5, 2018

Coverage Status

Coverage decreased (-0.03%) to 82.53% when pulling dc6f761 on fnothaft:issues/1806-genotypes-to-variants into aa43a56 on bigdatagenomics:master.

2 similar comments
@coveralls

This comment has been minimized.

coveralls commented Feb 5, 2018

Coverage Status

Coverage decreased (-0.03%) to 82.53% when pulling dc6f761 on fnothaft:issues/1806-genotypes-to-variants into aa43a56 on bigdatagenomics:master.

@coveralls

This comment has been minimized.

coveralls commented Feb 5, 2018

Coverage Status

Coverage decreased (-0.03%) to 82.53% when pulling dc6f761 on fnothaft:issues/1806-genotypes-to-variants into aa43a56 on bigdatagenomics:master.

@coveralls

This comment has been minimized.

coveralls commented Feb 5, 2018

Coverage Status

Coverage increased (+0.1%) to 82.691% when pulling 3a1b677 on fnothaft:issues/1806-genotypes-to-variants into c691356 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 5, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2644/
Test PASSed.

@fnothaft

This comment has been minimized.

Member

fnothaft commented Feb 9, 2018

This is good to go from my side now.

Does not perform any filtering looking at whether the variant was called
or not. By default, does not deduplicate variants. By default, does not
deduplicate variants.

This comment has been minimized.

@heuermh

heuermh Feb 9, 2018

Member

Doc comment needs deduplicating.

This comment has been minimized.

@fnothaft

fnothaft Feb 13, 2018

Member

Ironic!

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 9, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2658/
Test PASSed.

@heuermh heuermh added this to Triage in Release 0.24.0 Feb 10, 2018

@fnothaft

This comment has been minimized.

Member

fnothaft commented Mar 1, 2018

Addressed reviewer comments.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Mar 1, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2686/
Test PASSed.

@heuermh

heuermh approved these changes Mar 1, 2018

@heuermh heuermh merged commit 7761e6e into bigdatagenomics:master Mar 1, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Member

heuermh commented Mar 1, 2018

Thank you, @fnothaft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment