New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SparkFiles.getRootDirectory in local mode. #1924

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
4 participants
@heuermh
Member

heuermh commented Feb 27, 2018

SparkFiles.getRootDirectory appears to be set correctly in local mode even if SparkEnv.get.driverTmpDir is not.

Changing the fallback here appears to help bigdatagenomics/cannoli#107 work in local mode.

@heuermh heuermh requested a review from fnothaft Feb 27, 2018

@coveralls

This comment has been minimized.

coveralls commented Feb 27, 2018

Coverage Status

Coverage remained the same at 82.581% when pulling 81a4c69 on heuermh:sparkfiles-get-local-mode into 26f0608 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 27, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2681/
Test PASSed.

@fnothaft fnothaft merged commit 0696fea into bigdatagenomics:master Feb 28, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
default Merged build finished.
Details

@heuermh heuermh deleted the heuermh:sparkfiles-get-local-mode branch Feb 28, 2018

@heuermh heuermh added this to the 0.24.0 milestone Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment