New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1840] Support adding VCF header lines from Python. #1930

Merged
merged 1 commit into from Mar 5, 2018

Conversation

Projects
None yet
4 participants
@fnothaft
Member

fnothaft commented Mar 1, 2018

Resolves #1840. Split header line functionality out into VCFSupportingGenomicRDD trait, which has a Scala/Java API for adding header lines. This is then mirrored in Python.

[ADAM-1840] Support adding VCF header lines from Python.
Resolves #1840. Split header line functionality out into VCFSupportingGenomicRDD
trait, which has a Scala/Java API for adding header lines. This is then mirrored
in Python.
@coveralls

This comment has been minimized.

coveralls commented Mar 1, 2018

Coverage Status

Coverage decreased (-0.2%) to 82.435% when pulling fca816a on fnothaft:issues/1840-add-header-lines into c691356 on bigdatagenomics:master.

2 similar comments
@coveralls

This comment has been minimized.

coveralls commented Mar 1, 2018

Coverage Status

Coverage decreased (-0.2%) to 82.435% when pulling fca816a on fnothaft:issues/1840-add-header-lines into c691356 on bigdatagenomics:master.

@coveralls

This comment has been minimized.

coveralls commented Mar 1, 2018

Coverage Status

Coverage decreased (-0.2%) to 82.435% when pulling fca816a on fnothaft:issues/1840-add-header-lines into c691356 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Mar 1, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2687/
Test PASSed.

@heuermh heuermh added this to the 0.24.0 milestone Mar 1, 2018

@heuermh

heuermh approved these changes Mar 5, 2018

@heuermh heuermh merged commit fbc7218 into bigdatagenomics:master Mar 5, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Member

heuermh commented Mar 5, 2018

Thank you, @fnothaft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment