Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1934] Clip phred values to 3233, instead of Int.MaxValue. #1936

Merged

Conversation

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Mar 3, 2018

Resolves #1934. When phred values underflow log space double precision floating point numbers, clip them to the lowest phred score representable as a log valued double (3233), instead of Int.MaxValue.

Resolves #1934. When phred values underflow log space double precision floating
point numbers, clip them to the lowest phred score representable as a log valued
double (3233), instead of Int.MaxValue.
@fnothaft fnothaft added this to the 0.24.0 milestone Mar 3, 2018
@coveralls
Copy link

@coveralls coveralls commented Mar 3, 2018

Coverage Status

Coverage decreased (-0.08%) to 82.612% when pulling 1adbabd on fnothaft:issues/1934-saturate-phred into babf839 on bigdatagenomics:master.

3 similar comments
@coveralls
Copy link

@coveralls coveralls commented Mar 3, 2018

Coverage Status

Coverage decreased (-0.08%) to 82.612% when pulling 1adbabd on fnothaft:issues/1934-saturate-phred into babf839 on bigdatagenomics:master.

@coveralls
Copy link

@coveralls coveralls commented Mar 3, 2018

Coverage Status

Coverage decreased (-0.08%) to 82.612% when pulling 1adbabd on fnothaft:issues/1934-saturate-phred into babf839 on bigdatagenomics:master.

@coveralls
Copy link

@coveralls coveralls commented Mar 3, 2018

Coverage Status

Coverage decreased (-0.08%) to 82.612% when pulling 1adbabd on fnothaft:issues/1934-saturate-phred into babf839 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Mar 4, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2691/
Test PASSed.

@heuermh
heuermh approved these changes Mar 4, 2018
@heuermh heuermh merged commit 8248447 into bigdatagenomics:master Mar 4, 2018
2 checks passed
2 checks passed
Codacy/PR Quality Review Good work! A positive pull request.
Details
@AmplabJenkins
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented Mar 4, 2018

Thank you, @fnothaft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants