Skip to content

/ adam

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAM-1939] Allow validation stringency to waive off FLAG arrays. #1940

Merged
merged 1 commit into from Mar 7, 2018
Merged

[ADAM-1939] Allow validation stringency to waive off FLAG arrays. #1940

merged 1 commit into from Mar 7, 2018

Conversation

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Mar 7, 2018

Resolves #1939.
@fnothaft fnothaft added this to the 0.24.0 milestone Mar 7, 2018
@fnothaft fnothaft requested a review from heuermh Mar 7, 2018
@coveralls
Copy link

@coveralls coveralls commented Mar 7, 2018 •
edited

Coverage Status

Coverage increased (+0.07%) to 82.532% when pulling 93b2510 on fnothaft:issues/1939-info-flag into f616784 on bigdatagenomics:master.
@coveralls
Copy link

@coveralls coveralls commented Mar 7, 2018

Coverage Status

Coverage increased (+0.07%) to 82.545% when pulling 7a7eae6 on fnothaft:issues/1939-info-flag into 4e773c5 on bigdatagenomics:master.
2 similar comments
@coveralls
Copy link

@coveralls coveralls commented Mar 7, 2018

Coverage Status

Coverage increased (+0.07%) to 82.545% when pulling 7a7eae6 on fnothaft:issues/1939-info-flag into 4e773c5 on bigdatagenomics:master.
@coveralls
Copy link

@coveralls coveralls commented Mar 7, 2018

Coverage Status

Coverage increased (+0.07%) to 82.545% when pulling 7a7eae6 on fnothaft:issues/1939-info-flag into 4e773c5 on bigdatagenomics:master.
@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Mar 7, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2698/
Test PASSed.
@heuermh
heuermh requested changes Mar 7, 2018
View changes
adam-core/src/test/scala/org/bdgenomics/adam/rdd/ADAMContextSuite.scala Outdated
@@ -482,14 +489,14 @@ class ADAMContextSuite extends ADAMFunSuite {
sparkTest("load vcf with a glob") {
val path = testFile("bqsr1.vcf").replace("bqsr1", "*")

val vcs = sc.loadVcf(path)
val vcs = sc.loadVcf(path, stringency = ValidationStringency.LENIENT)

This comment has been minimized.

Sign in to view
@heuermh

heuermh Mar 7, 2018
Member

Sorry to be a pain, could test files that are invalid be moved to a subdirectory so that the glob doesn't pick them up?

This comment has been minimized.

Sign in to view
@fnothaft

fnothaft Mar 7, 2018
Author Member

+1, SGTM
Frank Austin Nothaft
[ADAM-1939] Allow validation stringency to waive off FLAG arrays.
Loading status checks…
93b2510 
Resolves #1939.
@fnothaft fnothaft force-pushed the fnothaft:issues/1939-info-flag branch from 7a7eae6 to 93b2510 Mar 7, 2018
@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Mar 7, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2700/
Test PASSed.
@heuermh
heuermh approved these changes Mar 7, 2018
View changes
@heuermh heuermh merged commit bc8c6f4 into bigdatagenomics:master Mar 7, 2018
2 checks passed
2 checks passed
Codacy/PR Quality Review Good work! A positive pull request.
Details
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented Mar 7, 2018

Thank you, @fnothaft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuermh heuermh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@fnothaft @coveralls @AmplabJenkins @heuermh