Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1914] Python profile needs to be specified for egg to be in distribution. #1946

Merged

Conversation

Projects
None yet
4 participants
@fnothaft
Copy link
Member

fnothaft commented Mar 7, 2018

Resolves #1914.

@fnothaft fnothaft added this to the 0.24.0 milestone Mar 7, 2018

@fnothaft fnothaft requested a review from heuermh Mar 7, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 7, 2018

Coverage Status

Coverage remained the same at 82.532% when pulling aec8eb3 on fnothaft:issues/1914-pyadam-from-distribution into 9ea870c on bigdatagenomics:master.

@heuermh

heuermh approved these changes Mar 7, 2018

@@ -29,7 +29,7 @@ git push origin ${branch}
git checkout -b maint_spark2_2.11-${release} ${branch}
git commit -a -m "Modifying pom.xml files for Spark 2, Scala 2.11 release."
mvn --batch-mode \
-P distribution \
-P python,r,distribution \

This comment has been minimized.

Copy link
@heuermh

heuermh Mar 7, 2018

Member

On further consideration, this won't work, will it? The only way I get the python and r profiles to build for me locally is to run separate mvn steps after first running mvn install, and then specify all the PY4J_ZIP PYSPARK_SUBMIT_ARGS etc. environment variables.

@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Mar 7, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2713/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Mar 8, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2715/
Test PASSed.

@heuermh

This comment has been minimized.

Copy link
Member

heuermh commented Mar 8, 2018

This works for me locally, so I will assume the release script will also work

$ cat release-excerpt.sh
#!/bin/bash

set -e -x -v

cd adam-python
virtualenv adam-release
. adam-release/bin/activate
make develop
deactivate
rm -rf adam-release
cd ..

mvn -P distribution install package

cd adam-r
R CMD build bdgenomics.adam
cd ..
@@ -27,6 +27,15 @@ git push origin ${branch}

# do spark 2, scala 2.11 release
git checkout -b maint_spark2_2.11-${release} ${branch}

cd adam-python

This comment has been minimized.

Copy link
@heuermh

heuermh Mar 8, 2018

Member

cd vs pushd?

@heuermh heuermh merged commit e8bbe36 into bigdatagenomics:master Mar 14, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
default Merged build finished.
Details
@heuermh

This comment has been minimized.

Copy link
Member

heuermh commented Mar 14, 2018

Thank you, @fnothaft

@fnothaft fnothaft deleted the fnothaft:issues/1914-pyadam-from-distribution branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.