Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set defaults to schemas #1972

Merged
merged 3 commits into from Jun 12, 2018
Merged

Set defaults to schemas #1972

merged 3 commits into from Jun 12, 2018

Conversation

@ffinfo
Copy link
Contributor

@ffinfo ffinfo commented Mar 27, 2018

For user convenience when working with scala

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Mar 27, 2018

Can one of the admins verify this patch?

@ffinfo
Copy link
Contributor Author

@ffinfo ffinfo commented Mar 27, 2018

Also changed to case classes, better native scala/dataset support

@heuermh
Copy link
Member

@heuermh heuermh commented May 22, 2018

Jenkins, test this please

@coveralls
Copy link

@coveralls coveralls commented May 22, 2018

Coverage Status

Coverage decreased (-0.02%) to 79.145% when pulling 0ec222d on ffinfo:set_defaults into 1bfddc6 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented May 22, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2769/
Test PASSed.

@heuermh
Copy link
Member

@heuermh heuermh commented May 23, 2018

Looks reasonable to me, thank you, @ffinfo!

@heuermh heuermh requested a review from fnothaft May 23, 2018
@heuermh
Copy link
Member

@heuermh heuermh commented Jun 6, 2018

@fnothaft milestone 0.24.1?

@heuermh heuermh mentioned this pull request Jun 11, 2018
@fnothaft fnothaft added this to the 0.24.1 milestone Jun 12, 2018
@heuermh heuermh merged commit afa55a4 into bigdatagenomics:master Jun 12, 2018
2 checks passed
2 checks passed
Codacy/PR Quality Review Good work! A positive pull request.
Details
@AmplabJenkins
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented Jun 12, 2018

Thank you, @ffinfo! Squashed and merged as commit afa55a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants