Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1697] Expand Illumina metadata regex to cover index sequences #2004

Merged
merged 2 commits into from Jun 28, 2018
Merged

[ADAM-1697] Expand Illumina metadata regex to cover index sequences #2004

merged 2 commits into from Jun 28, 2018

Conversation

@pauldwolfe
Copy link
Contributor

@pauldwolfe pauldwolfe commented Jun 28, 2018

Now includes possible index sequence characters.

Now includes possible index sequence characters.
@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jun 28, 2018

Can one of the admins verify this patch?

@pauldwolfe
Copy link
Contributor Author

@pauldwolfe pauldwolfe commented Jun 28, 2018

This change was discussed in gitter with @heuermh (actually he made the change, I just wrote the test and added the test resources). Perhaps he can review it.

Copy link
Member

@fnothaft fnothaft left a comment

+1, thanks for the addition!


sparkTest("Paired read names with index sequences in read names can grouped into fragments") {
val path1 = testFile("read_names_with_index_sequences_pair1.fq")
val path2 = testFile("read_names_with_index_sequences_pair1.fq")

This comment has been minimized.

@heuermh

heuermh Jun 28, 2018
Member

I think this line should be "read_names_with_index_sequences_pair2.fq"

@heuermh heuermh changed the title [ADAM-1697] Expand illumina metadata regex [ADAM-1697] Expand Illumina metadata regex to cover index sequences Jun 28, 2018
@heuermh
Copy link
Member

@heuermh heuermh commented Jun 28, 2018

Fixes #1697

Fix typo in unit test.
@pauldwolfe
Copy link
Contributor Author

@pauldwolfe pauldwolfe commented Jun 28, 2018

Fixed change request from @heuermh

@heuermh
Copy link
Member

@heuermh heuermh commented Jun 28, 2018

Thank you, @pauldwolfe!

@heuermh
Copy link
Member

@heuermh heuermh commented Jun 28, 2018

Jenkins, test this please

@heuermh
Copy link
Member

@heuermh heuermh commented Jun 28, 2018

Jenkins, add to whitelist

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jun 28, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2776/
Test PASSed.

@heuermh heuermh merged commit e7cbfcd into bigdatagenomics:master Jun 28, 2018
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
@AmplabJenkins
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented Jun 28, 2018

Squashed and merged as commit e7cbfcd, thank you, @pauldwolfe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants