Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-936] Use github-changes-maven-plugin to update CHANGES.md. #2014

Merged

Conversation

@heuermh
Copy link
Member

@heuermh heuermh commented Jul 12, 2018

Fixes #936. I've tested the plugin but not as part of the release script.

@heuermh heuermh added this to the 0.24.1 milestone Jul 12, 2018
@heuermh heuermh requested a review from fnothaft Jul 12, 2018
@coveralls
Copy link

@coveralls coveralls commented Jul 12, 2018

Coverage Status

Coverage remained the same at 78.933% when pulling 2f14abf on heuermh:github-changes-maven-plugin into 8e8007e on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jul 12, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2783/

Build result: ABORTED

[...truncated 7 lines...] > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/2014/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains cd71bcd # timeout=10Checking out Revision cd71bcd (origin/pr/2014/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f cd71bcd39dc48ab864786071dc87031fd6dff144First time build. Skipping changelog.Triggering ADAM-prb ? 2.7.3,2.11,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.1,centosADAM-prb ? 2.7.3,2.11,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.11,2.2.1,centos completed with result ABORTEDNotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@heuermh
Copy link
Member Author

@heuermh heuermh commented Jul 12, 2018

Jenkins, retest this please

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jul 12, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2784/
Test PASSed.

@heuermh heuermh changed the title [ADAM-936] Use github-changes-maven-plugin to updated CHANGES.md. [ADAM-936] Use github-changes-maven-plugin to update CHANGES.md. Aug 27, 2018
@heuermh heuermh requested a review from akmorrow13 Aug 30, 2018
#./scripts/changelog.sh $1 | tee CHANGES.md
#git commit -a -m "Modifying changelog."
# update changelog per Github milestone
mvn com.github.heuermh.maven.plugin.changes:github-changes-maven-plugin:1.0:github-changes -DmilestoneId=${milestone}
Copy link
Contributor

@akmorrow13 akmorrow13 Aug 30, 2018

Is this your own plugin?

Copy link
Member Author

@heuermh heuermh Aug 30, 2018

Yeah, so if specifying the Github milestoneId directly isn't the right interface, I could change it to do something else.

There is more discussion in the linked issue.

Copy link
Contributor

@akmorrow13 akmorrow13 Aug 30, 2018

Ah ok

@fnothaft fnothaft merged commit 55c6f18 into bigdatagenomics:master Oct 16, 2018
1 check passed
@heuermh heuermh deleted the github-changes-maven-plugin branch Oct 17, 2018
@heuermh
Copy link
Member Author

@heuermh heuermh commented Oct 17, 2018

Thank you, @fnothaft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants