New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1988] Add copyVariantEndToAttribute method to support gVCF END attribute … #2017

Merged
merged 1 commit into from Aug 30, 2018

Conversation

Projects
None yet
5 participants
@heuermh
Copy link
Member

heuermh commented Jul 17, 2018

…when not including nested variant annotations.

Fixes #1988

Add copyVariantEndToAttribute method to support gVCF END attribute wh…
…en not including nested variant annotations.

@heuermh heuermh added this to the 0.24.1 milestone Jul 17, 2018

@heuermh heuermh requested a review from fnothaft Jul 17, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 17, 2018

Coverage Status

Coverage increased (+0.1%) to 79.072% when pulling 81c49ae on heuermh:gvcf-end into 8e8007e on bigdatagenomics:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 17, 2018

Coverage Status

Coverage increased (+0.1%) to 79.072% when pulling 81c49ae on heuermh:gvcf-end into 8e8007e on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Jul 17, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2787/

Build result: FAILURE

[...truncated 7 lines...] > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/2017/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains 625ec43 # timeout=10Checking out Revision 625ec43 (origin/pr/2017/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 625ec4378e26df3d71541485419a8f7a67388944First time build. Skipping changelog.Triggering ADAM-prb ? 2.7.3,2.11,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.1,centosADAM-prb ? 2.7.3,2.11,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.11,2.2.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@fnothaft

This comment has been minimized.

Copy link
Member

fnothaft commented Jul 18, 2018

Jenkins, retest this please.

@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Jul 18, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2790/
Test PASSed.

@heuermh

This comment has been minimized.

Copy link
Member

heuermh commented Aug 30, 2018

@akmorrow13 This one just needs a merge

@akmorrow13 akmorrow13 merged commit 3542342 into bigdatagenomics:master Aug 30, 2018

1 check passed

default Merged build finished.
Details

@heuermh heuermh deleted the heuermh:gvcf-end branch Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment