Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-2079] Expand illumina metadata regex to include "N" character #2081

Merged
merged 1 commit into from Nov 7, 2018
Merged

[ADAM-2079] Expand illumina metadata regex to include "N" character #2081

merged 1 commit into from Nov 7, 2018

Conversation

@pauldwolfe
Copy link
Contributor

@pauldwolfe pauldwolfe commented Nov 7, 2018

Fixes #2079

Adds the "N" character to the regex to both the record converter and input format as they can be present in sample names (found a few inCOLO829 sample).
Also adjusts the test data to include an N in the sample name.

input format as they can be present in sample names (found a few in
COLO829 sample). Also adjusts the test data to include an N in the
sample name.
@coveralls
Copy link

@coveralls coveralls commented Nov 7, 2018

Coverage Status

Coverage remained the same at 79.206% when pulling ed965eb on pauldwolfe:illumina_metadata_fix into fc67969 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Nov 7, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2854/
Test PASSed.

@heuermh heuermh added this to the 0.25.0 milestone Nov 7, 2018
@heuermh
heuermh approved these changes Nov 7, 2018
@heuermh heuermh changed the title Expand illumina metadata regex to include "N" character [ADAM-2079] Expand illumina metadata regex to include "N" character Nov 7, 2018
@heuermh heuermh merged commit 1d50c71 into bigdatagenomics:master Nov 7, 2018
1 check passed
1 check passed
@AmplabJenkins
default Merged build finished.
Details
@heuermh
Copy link
Member

@heuermh heuermh commented Nov 7, 2018

Thank you, @pauldwolfe!

@pauldwolfe pauldwolfe deleted the pauldwolfe:illumina_metadata_fix branch Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants