Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use parquet-scala_2.11 fork #2108

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@ryan-williams
Copy link
Member

ryan-williams commented Dec 28, 2018

I built parquet-scala 1.8.3 against Scala 2.11 and released it as org.lasersonlab.apache.parquet:parquet-scala_2.11:1.8.3

This fixes a petrified old ADAM build-smell: using parquet-scala_2.10 in 2.11 builds.

I'll probably PR some of it upstream, but you can merge this first if you like. I put a 2.10 version under the same forked org.lasersonlab.apache.parquet group so the existing cross-build here should work with it.

I started on this because I'm lifting my Spark stack onto 2.12, and parquet-scala_2.10 does in fact break things there, so I also built and released parquet-scala_2.12 for 1.8.3, 1.10.0, and a 1.12.0 cut from HEAD while I was trying to figure out what I wanted.

Using that {2.12,1.10.0} version, my old adam-core fork builds+tests against {Spark 2.4, Scala 2.12}, which bodes well for #2044! I plan to publish a version of it soon so I will follow up if I encounter anything else of note.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 28, 2018

Coverage Status

Coverage remained the same at 78.677% when pulling 9e01b92 on ryan-williams:ps into a26ee37 on bigdatagenomics:master.

@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Dec 28, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2912/

Build result: FAILURE

GitHub pull request #2108 of commit d5e4e16 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prbWiping out workspace first.Cloning the remote Git repositoryCloning repository https://github.com/bigdatagenomics/adam.git > git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > git rev-parse origin/pr/2108/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains 9a3c578 # timeout=10Checking out Revision 9a3c578 (origin/pr/2108/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 9a3c578c5b8dbaf398dbc83c87d00d6e7b604a41First time build. Skipping changelog.Triggering ADAM-prb ? 2.7.5,2.11,2.2.2,ubuntuADAM-prb ? 2.7.5,2.11,2.2.2,ubuntu completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@ryan-williams

This comment has been minimized.

Copy link
Member Author

ryan-williams commented Dec 28, 2018

Seems like it just timed out without running any tests; lmk how to proceed

@heuermh

This comment has been minimized.

Copy link
Member

heuermh commented Dec 28, 2018

Jenkins, retest this please

@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Dec 28, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2914/

Build result: FAILURE

GitHub pull request #2108 of commit d5e4e16 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prbWiping out workspace first.Cloning the remote Git repositoryCloning repository https://github.com/bigdatagenomics/adam.git > git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > git rev-parse origin/pr/2108/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains 9a3c578 # timeout=10Checking out Revision 9a3c578 (origin/pr/2108/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 9a3c578c5b8dbaf398dbc83c87d00d6e7b604a41First time build. Skipping changelog.Triggering ADAM-prb ? 2.7.5,2.11,2.2.2,ubuntuADAM-prb ? 2.7.5,2.11,2.2.2,ubuntu completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@heuermh

This comment has been minimized.

Copy link
Member

heuermh commented Jan 4, 2019

@ryan-williams Could you rebase to pull in #2109? That might fix the Jenkins issue.

@ryan-williams ryan-williams force-pushed the ryan-williams:ps branch from d5e4e16 to 9e01b92 Jan 5, 2019

@ryan-williams

This comment has been minimized.

Copy link
Member Author

ryan-williams commented Jan 5, 2019

Jenkins, retest this please

@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Jan 5, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2923/
Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.