New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SAM to ADAM conversion #220

Merged
merged 1 commit into from Apr 22, 2014

Conversation

Projects
None yet
4 participants
@ihodes
Member

ihodes commented Apr 18, 2014

Parse out the OQ (original quality) common alignment option field from SAM files and populate ADAMRecords with it (if it exists).

Closes #219

Isaac Hodes
Update SAM to ADAM conversion
Parse out the OQ (original quality) common attribute and populate the ADAMRecord with it
(if it exists).
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 18, 2014

Can one of the admins verify this patch?

AmplabJenkins commented Apr 18, 2014

Can one of the admins verify this patch?

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 18, 2014

Can one of the admins verify this patch?

AmplabJenkins commented Apr 18, 2014

Can one of the admins verify this patch?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Apr 18, 2014

Member

Jenkins, add to whitelist and test this please.

On Fri, Apr 18, 2014 at 9:54 AM, UCB AMPLab notifications@github.comwrote:

Can one of the admins verify this patch?

Reply to this email directly or view it on GitHubhttps://github.com//pull/220#issuecomment-40824121
.

Member

fnothaft commented Apr 18, 2014

Jenkins, add to whitelist and test this please.

On Fri, Apr 18, 2014 at 9:54 AM, UCB AMPLab notifications@github.comwrote:

Can one of the admins verify this patch?

Reply to this email directly or view it on GitHubhttps://github.com//pull/220#issuecomment-40824121
.

@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Apr 22, 2014

Member

Jenkins, test this please.

Member

massie commented Apr 22, 2014

Jenkins, test this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins commented Apr 22, 2014

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/290/

@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Apr 22, 2014

Member

Sorry, @ihodes, Jenkins is being cranky. This test failure is an not an issue with your change. Jenkins, test this please.

Member

massie commented Apr 22, 2014

Sorry, @ihodes, Jenkins is being cranky. This test failure is an not an issue with your change. Jenkins, test this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 22, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/292/

AmplabJenkins commented Apr 22, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/292/

massie added a commit that referenced this pull request Apr 22, 2014

@massie massie merged commit 8252f35 into bigdatagenomics:master Apr 22, 2014

1 check passed

default Merged build finished.
Details
@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Apr 22, 2014

Member

Thanks, Isaac!

Member

massie commented Apr 22, 2014

Thanks, Isaac!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment