Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix ReferenceRegion from ADAMRecord #226
All automated tests passed.
To clarify there are two "end" fields, one in RichADAMRecord and one in ReferenceRegion.
For ReferenceRegion - the docs state:
RichADAMRecord end is also exclusive and (start, end) also define a 0-based half-open interval. Currently when you create a ReferenceRegion from a RichADAMRecord, it sets region.start = read.start and region.end = (read.end + 1). Since both are already exclusive, half-open intervals the start and end should be equal.
On other hand, the documentation on the apply(RichADAMRecord) method is somewhat conflicting:
Ah! I see. Just to confirm my understanding then, you're saying that for the read:
Wrapping this as a RichADAMRecord, and calling end, would return 5 + 1 = 6, and that the current code to go RichADAMRecord --> ReferenceRegion then in turn (incorrectly) bumps 6 + 1 = 7.
Is my understanding of this correct?