New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate mdtag field #230

Merged
merged 1 commit into from Apr 29, 2014

Conversation

Projects
None yet
6 participants
@arahuja
Contributor

arahuja commented Apr 25, 2014

For issue #229 - these fields seem to be duplicated. If there is a reason for both fields, feel free to close this

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Apr 25, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/301/

AmplabJenkins commented Apr 25, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/301/

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft
Member

fnothaft commented Apr 25, 2014

+1

@nealsid

This comment has been minimized.

Show comment
Hide comment
@nealsid

nealsid Apr 25, 2014

Contributor

+1

Contributor

nealsid commented Apr 25, 2014

+1

@jey

This comment has been minimized.

Show comment
Hide comment
@jey

jey Apr 25, 2014

Contributor

+1 (tentative)

Just to confirm: it doesn't make sense for an unmapped read to have an MD tag, right?

Contributor

jey commented Apr 25, 2014

+1 (tentative)

Just to confirm: it doesn't make sense for an unmapped read to have an MD tag, right?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Apr 25, 2014

Member

@jey correct; I think both handle the unmapped case identically.

Jey Kottalam notifications@github.com wrote:

+1 (tentative)

Just to confirm: it doesn't make sense for an unmapped read to have an MD tag, right?


Reply to this email directly or view it on GitHub:
#230 (comment)

+1 (tentative)

Just to confirm: it doesn't make sense for an unmapped read to have an MD tag, right?


Reply to this email directly or view it on GitHub.

Member

fnothaft commented Apr 25, 2014

@jey correct; I think both handle the unmapped case identically.

Jey Kottalam notifications@github.com wrote:

+1 (tentative)

Just to confirm: it doesn't make sense for an unmapped read to have an MD tag, right?


Reply to this email directly or view it on GitHub:
#230 (comment)

+1 (tentative)

Just to confirm: it doesn't make sense for an unmapped read to have an MD tag, right?


Reply to this email directly or view it on GitHub.

massie added a commit that referenced this pull request Apr 29, 2014

Merge pull request #230 from hammerlab/mdtag-dup
Remove duplicate mdtag field

@massie massie merged commit 412fc2c into bigdatagenomics:master Apr 29, 2014

1 check passed

default Merged build finished.
Details
@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Apr 29, 2014

Member

Thanks, Neal!

Member

massie commented Apr 29, 2014

Thanks, Neal!

@arahuja arahuja deleted the hammerlab:mdtag-dup branch Apr 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment