New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sample ID field in genotype nullable. #246

Merged
merged 1 commit into from May 22, 2014

Conversation

Projects
None yet
3 participants
@fnothaft
Member

fnothaft commented May 22, 2014

I missed one field in #245... this change makes sample ID (which had no default value after #238/#243) nullable in ADAMGenotype.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins May 22, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/325/

AmplabJenkins commented May 22, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/325/

massie added a commit that referenced this pull request May 22, 2014

Merge pull request #246 from fnothaft/genotype-fix-sample-id
Making sample ID field in genotype nullable.

@massie massie merged commit c6deb89 into bigdatagenomics:master May 22, 2014

1 check passed

default Merged build finished.
Details

@fnothaft fnothaft deleted the fnothaft:genotype-fix-sample-id branch Jul 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment