New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #244, Fragments were incorrect order and incomplete #247

Merged
merged 1 commit into from May 27, 2014

Conversation

Projects
None yet
3 participants
@arahuja
Contributor

arahuja commented May 27, 2014

There were two issues here:

  1. the fragments were indexed in the wrong order (the list by generated by placing the NEXT fragment at the front of the list and giving that index 0.
  2. Only the first fragment was taken off on each addition (assuming that the sequence string was not more than 2x fragment length) If it was the rest of the sequence would not taken off until the next sequence was adding making the last sequence very long and >> maxFragmentLength possibly.
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins May 27, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/326/

AmplabJenkins commented May 27, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/326/

massie added a commit that referenced this pull request May 27, 2014

Merge pull request #247 from hammerlab/issue-244
For #244, Fragments were incorrect order and incomplete

@massie massie merged commit db750cc into bigdatagenomics:master May 27, 2014

1 check passed

default Merged build finished.
Details
@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie May 27, 2014

Member

Thanks, Arun!

Member

massie commented May 27, 2014

Thanks, Arun!

@arahuja arahuja deleted the hammerlab:issue-244 branch May 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment