New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic changes to FastaConverter and FastaConverterSuite. #249

Merged
merged 1 commit into from May 29, 2014

Conversation

Projects
None yet
3 participants
@tdanford
Contributor

tdanford commented May 29, 2014

Just making a few little cosmetic changes to FastaConverter, to make part of the code more readable.

Also, added a second condition to one of the tests in FastaConverterSuite, to check that the reassembled
sequence (which had been created, but wasn't being used) matched what was in the original file.

These changes are minor enough that I don't believe they need a separate entry in the CHANGES file.

Cosmetic changes to FastaConverter and FastaConverterSuite.
Just making a few little cosmetic changes to FastaConverter, to make part of the code more readable.

Also, added a second condition to one of the tests in FastaConverterSuite, to check that the reassembled
sequence (which had been created, but wasn't being used) matched what was in the original file.
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins May 29, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/329/

AmplabJenkins commented May 29, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/329/

massie added a commit that referenced this pull request May 29, 2014

Merge pull request #249 from genomebridge/cosmetic-changes
Cosmetic changes to FastaConverter and FastaConverterSuite.

@massie massie merged commit 2ec906c into bigdatagenomics:master May 29, 2014

1 check passed

default Merged build finished.
Details
@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie May 29, 2014

Member

Thanks, Timothy!

Member

massie commented May 29, 2014

Thanks, Timothy!

@tdanford tdanford deleted the broadinstitute:cosmetic-changes branch May 29, 2014

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford May 29, 2014

Contributor

Ironically, not rebased off the latest master! :-/

Contributor

tdanford commented May 29, 2014

Ironically, not rebased off the latest master! :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment