New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an 'args' parameter to the plugin framework. #258

Merged
merged 1 commit into from Jun 8, 2014

Conversation

Projects
None yet
3 participants
@tdanford
Contributor

tdanford commented Jun 6, 2014

PluginExecutor now takes a plugin_args argument, whose value is now passed through as
an argument to the 'run' method of ADAMPlugin.

Added a new example (test) plugin, TakeNPlugin, which shows a simple use of this parameter.

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Jun 6, 2014

Contributor

This is a fix to #130

Contributor

tdanford commented Jun 6, 2014

This is a fix to #130

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jun 6, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/348/

AmplabJenkins commented Jun 6, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/348/

Adding an 'args' parameter to the plugin framework.
PluginExecutor now takes a plugin_args argument, whose value is now passed through as
an argument to the 'run' method of ADAMPlugin.

Added a new example (test) plugin, TakeNPlugin, which shows a simple use of this parameter.
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jun 8, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/355/

AmplabJenkins commented Jun 8, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/355/

fnothaft added a commit that referenced this pull request Jun 8, 2014

Merge pull request #258 from genomebridge/plugin-args
Adding an 'args' parameter to the plugin framework.

@fnothaft fnothaft merged commit 712c37e into bigdatagenomics:master Jun 8, 2014

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jun 8, 2014

Member

Merged! Thanks @tdanford.

Member

fnothaft commented Jun 8, 2014

Merged! Thanks @tdanford.

@tdanford tdanford deleted the broadinstitute:plugin-args branch Jun 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment