New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-388] Sets Kryo serialization with --conf args #396

Merged
merged 1 commit into from Sep 29, 2014

Conversation

Projects
None yet
3 participants
@laserson
Contributor

laserson commented Sep 25, 2014

Spark 1.0 did not support --conf, meaning we had to package a properties file just for Kryo. Now that we've bumped up Spark to 1.1, we can use the command line options instead. Fixes #388.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 25, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/266/

Build result: FAILURE

GitHub pull request #396 of commit 3ac132a automatically merged.[EnvInject] - Loading node environment variables.Building remotely on test03.amplab (CentOS 6.5) (test03 centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/396/merge^{commit} # timeout=10Checking out Revision 7b5e356 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 7b5e356 > git rev-list c6703100935589fbf08b7dd7f62fa59728f34606 # timeout=10Triggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.2.0,centosADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILURE

AmplabJenkins commented Sep 25, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/266/

Build result: FAILURE

GitHub pull request #396 of commit 3ac132a automatically merged.[EnvInject] - Loading node environment variables.Building remotely on test03.amplab (CentOS 6.5) (test03 centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/396/merge^{commit} # timeout=10Checking out Revision 7b5e356 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 7b5e356 > git rev-list c6703100935589fbf08b7dd7f62fa59728f34606 # timeout=10Triggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.2.0,centosADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILURE

@laserson

This comment has been minimized.

Show comment
Hide comment
@laserson

laserson Sep 25, 2014

Contributor

Hmm...build passes on my local machine.

Contributor

laserson commented Sep 25, 2014

Hmm...build passes on my local machine.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 26, 2014

Member

@laserson the build is OK, it fails in an integration test phase. Can you try running ./scripts/jenkins-test on your local?

Member

fnothaft commented Sep 26, 2014

@laserson the build is OK, it fails in an integration test phase. Can you try running ./scripts/jenkins-test on your local?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 26, 2014

Member

Otherwise, this looks +1 to me!

Member

fnothaft commented Sep 26, 2014

Otherwise, this looks +1 to me!

Uri Laserson
[ADAM-388][ADAM-398] Sets Kryo serialization with --conf args
Fixes #388
Fixes #398: Updated `jenkins-test` script to dnload Spark 1.1
@laserson

This comment has been minimized.

Show comment
Hide comment
@laserson

laserson Sep 29, 2014

Contributor

The failure was because of #398. Fixed now.

Contributor

laserson commented Sep 29, 2014

The failure was because of #398. Fixed now.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 29, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/267/

AmplabJenkins commented Sep 29, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/267/

fnothaft added a commit that referenced this pull request Sep 29, 2014

Merge pull request #396 from laserson/conf-args
[ADAM-388] Sets Kryo serialization with --conf args

@fnothaft fnothaft merged commit 4dca068 into bigdatagenomics:master Sep 29, 2014

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 29, 2014

Member

Merged! Thanks @laserson, and my apologies for forgetting to update the jenkins-test script when we moved to 1.1...

Member

fnothaft commented Sep 29, 2014

Merged! Thanks @laserson, and my apologies for forgetting to update the jenkins-test script when we moved to 1.1...

@laserson laserson deleted the laserson:conf-args branch Oct 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment