New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-416] Removing 'ADAM' prefix #418

Merged
merged 1 commit into from Oct 14, 2014

Conversation

Projects
None yet
4 participants
@tdanford
Contributor

tdanford commented Oct 14, 2014

This initial commit includes just the change for the ADAMFeaturesContext
class/object.

I'll add more commits (and accept PRs to this PR!) which remove the prefix from other classes.

Fixes #416.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 14, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/297/
Test PASSed.

AmplabJenkins commented Oct 14, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/297/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 14, 2014

Member

+1; LGTM!

Member

fnothaft commented Oct 14, 2014

+1; LGTM!

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 14, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/298/

Build result: FAILURE

GitHub pull request #418 of commit 5f7d259 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/418/merge^{commit} # timeout=10Checking out Revision 1dcfbb8c88204752ca032bf98fdf0ad480c735cb (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 1dcfbb8c88204752ca032bf98fdf0ad480c735cb > git rev-list fa32bbf # timeout=10First time build. Skipping changelog.Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result SUCCESSADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

AmplabJenkins commented Oct 14, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/298/

Build result: FAILURE

GitHub pull request #418 of commit 5f7d259 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/418/merge^{commit} # timeout=10Checking out Revision 1dcfbb8c88204752ca032bf98fdf0ad480c735cb (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 1dcfbb8c88204752ca032bf98fdf0ad480c735cb > git rev-list fa32bbf # timeout=10First time build. Skipping changelog.Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result SUCCESSADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 14, 2014

Member

Jenkins, retest this please.

Member

fnothaft commented Oct 14, 2014

Jenkins, retest this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 14, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/299/
Test PASSed.

AmplabJenkins commented Oct 14, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/299/
Test PASSed.

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Oct 14, 2014

Contributor

This fixes the obvious classes/objects that I can see. I also cleaned up some of the method names that contained extraneous 'adam' particles. Anyone see anything else I missed?

Contributor

tdanford commented Oct 14, 2014

This fixes the obvious classes/objects that I can see. I also cleaned up some of the method names that contained extraneous 'adam' particles. Anyone see anything else I missed?

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Oct 14, 2014

Contributor

When this builds, I'll squash down into a single commit.

Contributor

tdanford commented Oct 14, 2014

When this builds, I'll squash down into a single commit.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 14, 2014

Member

I'd say it's pretty clean now:

adam fnothaft$ git status
HEAD detached at tdanford/remove-adam-prefix
nothing added to commit (use "git add" to track)
adam fnothaft$ grep -i adam -R adam-core/src/ | grep -v org.bdgenomics.adam | grep -v adamLoad
adam-core/src//main/resources/git.properties:git.commit.message.full=Merge pull request \#404 from tdanford/gene-models\n\n[ADAM-327] Adding gene, transcript, and exon models.
adam-core/src//main/resources/git.properties:git.commit.id.describe=adam-parent-0.14.0-31-gbeec466
adam-core/src//main/resources/git.properties:git.remote.origin.url=git@github.com\:fnothaft/adam.git
adam-core/src//main/resources/log4j.properties:log4j.appender.logfile.file=adam.log
Binary file adam-core/src//test/resources/parquet_lister_dir/small_adam_A.fgenotype matches
Binary file adam-core/src//test/resources/parquet_lister_dir/small_adam_B.fgenotype matches
adam fnothaft$ 
Member

fnothaft commented Oct 14, 2014

I'd say it's pretty clean now:

adam fnothaft$ git status
HEAD detached at tdanford/remove-adam-prefix
nothing added to commit (use "git add" to track)
adam fnothaft$ grep -i adam -R adam-core/src/ | grep -v org.bdgenomics.adam | grep -v adamLoad
adam-core/src//main/resources/git.properties:git.commit.message.full=Merge pull request \#404 from tdanford/gene-models\n\n[ADAM-327] Adding gene, transcript, and exon models.
adam-core/src//main/resources/git.properties:git.commit.id.describe=adam-parent-0.14.0-31-gbeec466
adam-core/src//main/resources/git.properties:git.remote.origin.url=git@github.com\:fnothaft/adam.git
adam-core/src//main/resources/log4j.properties:log4j.appender.logfile.file=adam.log
Binary file adam-core/src//test/resources/parquet_lister_dir/small_adam_A.fgenotype matches
Binary file adam-core/src//test/resources/parquet_lister_dir/small_adam_B.fgenotype matches
adam fnothaft$ 
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 14, 2014

Member

Sorry, ignore the above; that was grep used incorrectly...

Member

fnothaft commented Oct 14, 2014

Sorry, ignore the above; that was grep used incorrectly...

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 14, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/300/

Build result: FAILURE

GitHub pull request #418 of commit 40fea82 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/418/merge^{commit} # timeout=10Checking out Revision 8d63104b079f827f990af9f354f6039fd485d413 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 8d63104b079f827f990af9f354f6039fd485d413 > git rev-list 1dcfbb8c88204752ca032bf98fdf0ad480c735cb # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result SUCCESSADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

AmplabJenkins commented Oct 14, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/300/

Build result: FAILURE

GitHub pull request #418 of commit 40fea82 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/418/merge^{commit} # timeout=10Checking out Revision 8d63104b079f827f990af9f354f6039fd485d413 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 8d63104b079f827f990af9f354f6039fd485d413 > git rev-list 1dcfbb8c88204752ca032bf98fdf0ad480c735cb # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result SUCCESSADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 14, 2014

Member

Here are a few ones I saw that I'm not sure about:

  • ADAMPredicate <-- IMO, these should ultimately be moved out of ADAM and into bdg-utils
  • ADAMMetrics/ADAMMetricsListener <-- I think these are OK

Otherwise, looks good here!

Member

fnothaft commented Oct 14, 2014

Here are a few ones I saw that I'm not sure about:

  • ADAMPredicate <-- IMO, these should ultimately be moved out of ADAM and into bdg-utils
  • ADAMMetrics/ADAMMetricsListener <-- I think these are OK

Otherwise, looks good here!

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 14, 2014

Member

@tdanford can you squash? This looks like some wonkyness with the new Jenkins setup; I'll ping @shaneknapp.

Member

fnothaft commented Oct 14, 2014

@tdanford can you squash? This looks like some wonkyness with the new Jenkins setup; I'll ping @shaneknapp.

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Oct 14, 2014

Contributor

I'll squash it when I'm back at my computer :-)

On Tue, Oct 14, 2014 at 11:18 AM, Frank Austin Nothaft
notifications@github.com wrote:

@tdanford can you squash? This looks like some wonkyness with the new Jenkins setup; I'll ping @shaneknapp.

Reply to this email directly or view it on GitHub:
#418 (comment)

Contributor

tdanford commented Oct 14, 2014

I'll squash it when I'm back at my computer :-)

On Tue, Oct 14, 2014 at 11:18 AM, Frank Austin Nothaft
notifications@github.com wrote:

@tdanford can you squash? This looks like some wonkyness with the new Jenkins setup; I'll ping @shaneknapp.

Reply to this email directly or view it on GitHub:
#418 (comment)

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Oct 14, 2014

Contributor

I don't think I renamed ADAMPredicate or the metrics stuff, right? (I agree with you, I would leave those.)

Contributor

tdanford commented Oct 14, 2014

I don't think I renamed ADAMPredicate or the metrics stuff, right? (I agree with you, I would leave those.)

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 14, 2014

Member

@tdanford ah, sorry, my comment was unclear; I was just pointing out classes that still had prefixes. I think we should drop the prefix from ADAMPredicate. I agree with you that the prefixes should stay on the metrics work.

Member

fnothaft commented Oct 14, 2014

@tdanford ah, sorry, my comment was unclear; I was just pointing out classes that still had prefixes. I think we should drop the prefix from ADAMPredicate. I agree with you that the prefixes should stay on the metrics work.

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Oct 14, 2014

Contributor

I think "Predicate" is so generic, I'm going ot leave the ADAM prefix on it for right now. It probably should be a different prefix in the future.

Contributor

tdanford commented Oct 14, 2014

I think "Predicate" is so generic, I'm going ot leave the ADAM prefix on it for right now. It probably should be a different prefix in the future.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 14, 2014

Member

@tdanford agreed; that's fine with me. I'm thinking we can reevaluate the predicate prefix if/when we move it to bdg-utils.

Member

fnothaft commented Oct 14, 2014

@tdanford agreed; that's fine with me. I'm thinking we can reevaluate the predicate prefix if/when we move it to bdg-utils.

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Oct 14, 2014

Contributor

yup, sounds good.

Contributor

tdanford commented Oct 14, 2014

yup, sounds good.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 14, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/301/

Build result: FAILURE

GitHub pull request #418 of commit 2df26b3 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/418/merge^{commit} # timeout=10Checking out Revision 2e436e08fbbf47c4bc13f76e4fc6242aade72735 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 2e436e08fbbf47c4bc13f76e4fc6242aade72735 > git rev-list 8d63104b079f827f990af9f354f6039fd485d413 # timeout=10Triggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILURE
Test FAILed.

AmplabJenkins commented Oct 14, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/301/

Build result: FAILURE

GitHub pull request #418 of commit 2df26b3 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/418/merge^{commit} # timeout=10Checking out Revision 2e436e08fbbf47c4bc13f76e4fc6242aade72735 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 2e436e08fbbf47c4bc13f76e4fc6242aade72735 > git rev-list 8d63104b079f827f990af9f354f6039fd485d413 # timeout=10Triggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILURE
Test FAILed.

[ADAM-416] Removing 'ADAM' prefix
Includes renames for:
* ADAMFeaturesContext class/object.
* ADAMNucleotideContigFragmentContext/RDDFunctions
* ADAMPileupContext/RDDFunctions and ADAMRODRDDFunctions
* AlignmentRecordContext, AlignmentRecordRDDFunctions
* Variation/GenotypeContext

ADAMContext, ADAMRDDFunctions, ADAMVCFInput/OutputFormats, ADAMMetric*,
and ADAMPredicate were all intentionally left unchanged.

Some method names were also changed, to remove the 'adam' prefix as a
particle within the name.
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 14, 2014

Member

Jenkins, retest this please.

Member

fnothaft commented Oct 14, 2014

Jenkins, retest this please.

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Oct 14, 2014

Contributor

Squashed and rebased.

Contributor

tdanford commented Oct 14, 2014

Squashed and rebased.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 14, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/302/

Build result: FAILURE

GitHub pull request #418 of commit a957395 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/418/merge^{commit} # timeout=10Checking out Revision db0f900 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f db0f900 > git rev-list 2e436e08fbbf47c4bc13f76e4fc6242aade72735 # timeout=10Triggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result SUCCESSADAM-prb » 1.0.4,centos completed with result SUCCESS
Test FAILed.

AmplabJenkins commented Oct 14, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/302/

Build result: FAILURE

GitHub pull request #418 of commit a957395 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/418/merge^{commit} # timeout=10Checking out Revision db0f900 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f db0f900 > git rev-list 2e436e08fbbf47c4bc13f76e4fc6242aade72735 # timeout=10Triggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result SUCCESSADAM-prb » 1.0.4,centos completed with result SUCCESS
Test FAILed.

@shaneknapp

This comment has been minimized.

Show comment
Hide comment
@shaneknapp

shaneknapp Oct 14, 2014

Contributor

Jenkins, test this please

Contributor

shaneknapp commented Oct 14, 2014

Jenkins, test this please

@shaneknapp

This comment has been minimized.

Show comment
Hide comment
@shaneknapp

shaneknapp Oct 14, 2014

Contributor

Jenkins, retest this please.

Contributor

shaneknapp commented Oct 14, 2014

Jenkins, retest this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 14, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/303/
Test PASSed.

AmplabJenkins commented Oct 14, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/303/
Test PASSed.

fnothaft added a commit that referenced this pull request Oct 14, 2014

Merge pull request #418 from tdanford/remove-adam-prefix
[ADAM-416] Removing 'ADAM' prefix

@fnothaft fnothaft merged commit d7bba84 into bigdatagenomics:master Oct 14, 2014

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 14, 2014

Member

Merged! Thanks @tdanford!

Member

fnothaft commented Oct 14, 2014

Merged! Thanks @tdanford!

@tdanford tdanford deleted the tdanford:remove-adam-prefix branch Oct 14, 2014

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Oct 14, 2014

Contributor

Thanks @fnothaft!

Contributor

tdanford commented Oct 14, 2014

Thanks @fnothaft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment