Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused val from Reads2Ref #458

Merged
merged 1 commit into from Nov 5, 2014

Conversation

massie
Copy link
Member

@massie massie commented Nov 3, 2014

No description provided.

@ryan-williams
Copy link
Member

heh, did you find this because this line is failing tests on my predicates PR #457 ?

@massie
Copy link
Member Author

massie commented Nov 3, 2014

Yes. Thanks for catching the bug.

@ryan-williams
Copy link
Member

funny. I'm worried that it was a real bug in my predicate logic though, so still trying to debug that; doesn't need to hold up this PR though of course

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/353/
Test PASSed.

@massie
Copy link
Member Author

massie commented Nov 3, 2014

Actually, there's more unused code. Cleaning it up now.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/355/
Test PASSed.

@massie
Copy link
Member Author

massie commented Nov 4, 2014

This is ready for someone to review. Should be an easy review -- just deleting code that isn't used.

@ryan-williams
Copy link
Member

lgtm, fwiw!

@fnothaft
Copy link
Member

fnothaft commented Nov 5, 2014

Jenkins, retest this please.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/367/
Test PASSed.

@tdanford
Copy link
Contributor

tdanford commented Nov 5, 2014

@massie will you rebase this? And then one of us (including me) would be happy to merge.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/372/
Test PASSed.

fnothaft added a commit that referenced this pull request Nov 5, 2014
Remove unused val from Reads2Ref
@fnothaft fnothaft merged commit 3954855 into bigdatagenomics:master Nov 5, 2014
@fnothaft
Copy link
Member

fnothaft commented Nov 5, 2014

Merged! Thanks @massie!

@massie massie deleted the reads2ref branch September 2, 2015 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants