New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused val from Reads2Ref #458

Merged
merged 1 commit into from Nov 5, 2014

Conversation

Projects
None yet
5 participants
@massie
Member

massie commented Nov 3, 2014

No description provided.

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Nov 3, 2014

Member

heh, did you find this because this line is failing tests on my predicates PR #457 ?

Member

ryan-williams commented Nov 3, 2014

heh, did you find this because this line is failing tests on my predicates PR #457 ?

@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Nov 3, 2014

Member

Yes. Thanks for catching the bug.

Member

massie commented Nov 3, 2014

Yes. Thanks for catching the bug.

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Nov 3, 2014

Member

funny. I'm worried that it was a real bug in my predicate logic though, so still trying to debug that; doesn't need to hold up this PR though of course

Member

ryan-williams commented Nov 3, 2014

funny. I'm worried that it was a real bug in my predicate logic though, so still trying to debug that; doesn't need to hold up this PR though of course

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Nov 3, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/353/
Test PASSed.

AmplabJenkins commented Nov 3, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/353/
Test PASSed.

@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Nov 3, 2014

Member

Actually, there's more unused code. Cleaning it up now.

Member

massie commented Nov 3, 2014

Actually, there's more unused code. Cleaning it up now.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Nov 3, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/355/
Test PASSed.

AmplabJenkins commented Nov 3, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/355/
Test PASSed.

@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Nov 4, 2014

Member

This is ready for someone to review. Should be an easy review -- just deleting code that isn't used.

Member

massie commented Nov 4, 2014

This is ready for someone to review. Should be an easy review -- just deleting code that isn't used.

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Nov 4, 2014

Member

lgtm, fwiw!

Member

ryan-williams commented Nov 4, 2014

lgtm, fwiw!

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 5, 2014

Member

Jenkins, retest this please.

Member

fnothaft commented Nov 5, 2014

Jenkins, retest this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Nov 5, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/367/
Test PASSed.

AmplabJenkins commented Nov 5, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/367/
Test PASSed.

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Nov 5, 2014

Contributor

@massie will you rebase this? And then one of us (including me) would be happy to merge.

Contributor

tdanford commented Nov 5, 2014

@massie will you rebase this? And then one of us (including me) would be happy to merge.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Nov 5, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/372/
Test PASSed.

AmplabJenkins commented Nov 5, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/372/
Test PASSed.

fnothaft added a commit that referenced this pull request Nov 5, 2014

Merge pull request #458 from massie/reads2ref
Remove unused val from Reads2Ref

@fnothaft fnothaft merged commit 3954855 into bigdatagenomics:master Nov 5, 2014

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 5, 2014

Member

Merged! Thanks @massie!

Member

fnothaft commented Nov 5, 2014

Merged! Thanks @massie!

@massie massie deleted the massie:reads2ref branch Sep 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment