New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix foreach block for vcf ingest #494

Merged
merged 1 commit into from Nov 21, 2014

Conversation

Projects
None yet
4 participants
@kyocum

kyocum commented Nov 20, 2014

foreach block for writing out vcf records seemed to accidentally include cleanup code as well. Simply moved it up to ensure cleanup code called once at the end of processing all the lines.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Nov 20, 2014

Can one of the admins verify this patch?

AmplabJenkins commented Nov 20, 2014

Can one of the admins verify this patch?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 20, 2014

Member

Jenkins, add to whitelist.

Member

fnothaft commented Nov 20, 2014

Jenkins, add to whitelist.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Nov 20, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/424/
Test PASSed.

AmplabJenkins commented Nov 20, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/424/
Test PASSed.

@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Nov 21, 2014

Member

Thanks, Kenneth!

Member

massie commented Nov 21, 2014

Thanks, Kenneth!

massie added a commit that referenced this pull request Nov 21, 2014

Merge pull request #494 from kyocum/fixVcfIngest
Fix foreach block for vcf ingest

@massie massie merged commit 995f72c into bigdatagenomics:master Nov 21, 2014

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment