New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't open non-.adam-extension files as ADAM files #523

Merged
merged 1 commit into from Dec 17, 2014

Conversation

Projects
None yet
4 participants
@ryan-williams
Member

ryan-williams commented Dec 16, 2014

No description provided.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Dec 16, 2014

Member

+1, LGTM! I'll keep it open for a bit in case anyone else wants to comment.

Member

fnothaft commented Dec 16, 2014

+1, LGTM! I'll keep it open for a bit in case anyone else wants to comment.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Dec 16, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/493/

Build result: FAILURE

GitHub pull request #523 of commit cb56e3a automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/523/merge^{commit} # timeout=10Checking out Revision 95d2a4b (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 95d2a4b > git rev-list b750165 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

AmplabJenkins commented Dec 16, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/493/

Build result: FAILURE

GitHub pull request #523 of commit cb56e3a automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/523/merge^{commit} # timeout=10Checking out Revision 95d2a4b (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 95d2a4b > git rev-list b750165 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

@shaneknapp

This comment has been minimized.

Show comment
Hide comment
@shaneknapp

shaneknapp Dec 16, 2014

Contributor

jenkins, test this please

Contributor

shaneknapp commented Dec 16, 2014

jenkins, test this please

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Dec 16, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/494/

Build result: FAILURE

GitHub pull request #523 of commit cb56e3a automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/523/merge^{commit} # timeout=10Checking out Revision 95d2a4b (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 95d2a4b > git rev-list b750165 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

AmplabJenkins commented Dec 16, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/494/

Build result: FAILURE

GitHub pull request #523 of commit cb56e3a automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/523/merge^{commit} # timeout=10Checking out Revision 95d2a4b (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 95d2a4b > git rev-list b750165 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Dec 16, 2014

Member

I believe my last commit should fix jenkins, which was failing due to needing some .adam extensions in the jenkins-test script

Member

ryan-williams commented Dec 16, 2014

I believe my last commit should fix jenkins, which was failing due to needing some .adam extensions in the jenkins-test script

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Dec 16, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/495/
Test PASSed.

AmplabJenkins commented Dec 16, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/495/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Dec 17, 2014

Member

@ryan-williams can you squash this down? I will merge once squashed.

Member

fnothaft commented Dec 17, 2014

@ryan-williams can you squash this down? I will merge once squashed.

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams
Member

ryan-williams commented Dec 17, 2014

done!

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Dec 17, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/499/
Test PASSed.

AmplabJenkins commented Dec 17, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/499/
Test PASSed.

fnothaft added a commit that referenced this pull request Dec 17, 2014

Merge pull request #523 from ryan-williams/adam-file
don't open non-.adam-extension files as ADAM files

@fnothaft fnothaft merged commit bceb3e1 into bigdatagenomics:master Dec 17, 2014

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Dec 17, 2014

Member

Merged! Thanks @ryan-williams!

Member

fnothaft commented Dec 17, 2014

Merged! Thanks @ryan-williams!

@ryan-williams ryan-williams deleted the ryan-williams:adam-file branch Dec 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment