New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-543][ADAM-544] Fix issues with ADAM scripts and classpath #545

Merged
merged 1 commit into from Jan 11, 2015

Conversation

Projects
None yet
3 participants
@laserson
Copy link
Contributor

laserson commented Jan 10, 2015

Note that this adds a Python utility script to bin/. Is this ok? Parsing the command line in bash just seemed so much less appetizing. This also has a workaround for SPARK-5185.

Fixes #543.
Fixes #544.

@fnothaft

This comment has been minimized.

Copy link
Member

fnothaft commented Jan 10, 2015

I'm OK with python.

@fnothaft

This comment has been minimized.

Copy link
Member

fnothaft commented Jan 10, 2015

Also, LGTM.

@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Jan 10, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/525/
Test PASSed.

@laserson laserson force-pushed the laserson:ADAM-543-jars branch from c43c4f7 to 61ad74a Jan 10, 2015

@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Jan 10, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/530/

Build result: FAILURE

GitHub pull request #545 of commit 61ad74a automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/545/merge^{commit} # timeout=10Checking out Revision 086157c11730413e8a91e3dfe3bcce19af086df5 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 086157c11730413e8a91e3dfe3bcce19af086df5 > git rev-list b409bd0004a00c2dac712b5c567963b3e013c8e3 # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosADAM-prb ? 2.2.0,centos completed with result SUCCESSADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result SUCCESS
Test FAILed.

@laserson

This comment has been minimized.

Copy link
Contributor Author

laserson commented Jan 10, 2015

Jenkins, retest this please.

@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Jan 11, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/532/
Test PASSed.

fnothaft added a commit that referenced this pull request Jan 11, 2015

Merge pull request #545 from laserson/ADAM-543-jars
[ADAM-543][ADAM-544] Fix issues with ADAM scripts and classpath

@fnothaft fnothaft merged commit 1ef172f into bigdatagenomics:master Jan 11, 2015

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Copy link
Member

fnothaft commented Jan 11, 2015

Merged! Thanks @laserson!

@laserson laserson deleted the laserson:ADAM-543-jars branch Jan 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment