New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Features2ADAMSuite use SparkFunSuite #558

Merged
merged 1 commit into from Jan 25, 2015

Conversation

Projects
None yet
3 participants
@fnothaft
Member

fnothaft commented Jan 25, 2015

Spawned by comments in #557; Features2ADAMSuite was using FunSuite and Features2ADAM.run() was creating a SparkContext. This led to address bind errors. This PR changes it so that we pass our own sc to Features2ADAM, and that this sc is created by a SparkFunSuite.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jan 25, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/558/

Build result: FAILURE

GitHub pull request #558 of commit 8436e65 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/558/merge^{commit} # timeout=10Checking out Revision e911b28 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f e911b28 > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/558/

Build result: FAILURE

GitHub pull request #558 of commit 8436e65 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/558/merge^{commit} # timeout=10Checking out Revision e911b28 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f e911b28 > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 25, 2015

Member

Whoops, error on my end.

Member

fnothaft commented Jan 25, 2015

Whoops, error on my end.

Follow on to [ADAM-557], makes Features2ADAMSuite use SparkFunSuite i…
…nstead of FunSuite to clean up logging issues.
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jan 25, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/559/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/559/
Test PASSed.

massie added a commit that referenced this pull request Jan 25, 2015

Merge pull request #558 from fnothaft/fix-features-test
Makes Features2ADAMSuite use SparkFunSuite

@massie massie merged commit 4087f16 into bigdatagenomics:master Jan 25, 2015

1 check passed

default Merged build finished.
Details
@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Jan 25, 2015

Member

Thanks, Frank!

Member

massie commented Jan 25, 2015

Thanks, Frank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment