New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-452] Fixes SM attribute on ADAM to BAM conversion. #586

Merged
merged 1 commit into from Feb 24, 2015

Conversation

Projects
None yet
4 participants
@andrewmchen
Member

andrewmchen commented Feb 23, 2015

Resolves #452. Small change that stops setting SM attribute to recordGroupSample in ADAM to BAM conversion.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Feb 23, 2015

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Feb 23, 2015

Member

Add to whitelist. Jenkins, test this please.

Member

massie commented Feb 23, 2015

Add to whitelist. Jenkins, test this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Feb 23, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/607/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/607/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Feb 23, 2015

Member

@andrewmchen looks good! Can you add unit tests to validate the change?

Member

fnothaft commented Feb 23, 2015

@andrewmchen looks good! Can you add unit tests to validate the change?

@andrewmchen

This comment has been minimized.

Show comment
Hide comment
@andrewmchen

andrewmchen Feb 24, 2015

Member

I added some unit tests in a new commit and squashed everything down to one commit.

Member

andrewmchen commented Feb 24, 2015

I added some unit tests in a new commit and squashed everything down to one commit.

@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Feb 24, 2015

Member

👍

Member

massie commented Feb 24, 2015

👍

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Feb 24, 2015

Member

Jenkins, retest this please.

Member

fnothaft commented Feb 24, 2015

Jenkins, retest this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Feb 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/608/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/608/
Test PASSed.

fnothaft added a commit that referenced this pull request Feb 24, 2015

Merge pull request #586 from andrewmchen/sm-bam-attribute-fix
[ADAM-452] Fixes SM attribute on ADAM to BAM conversion.

@fnothaft fnothaft merged commit 94f4841 into bigdatagenomics:master Feb 24, 2015

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Feb 24, 2015

Member

Merged! Thanks @andrewmchen!

Member

fnothaft commented Feb 24, 2015

Merged! Thanks @andrewmchen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment