New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-589] Removed pileup code. #590

Merged
merged 1 commit into from Feb 26, 2015

Conversation

Projects
None yet
4 participants
@fnothaft
Member

fnothaft commented Feb 25, 2015

Resolves #589.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Feb 25, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/610/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/610/
Test PASSed.

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Feb 25, 2015

Contributor

This code has been a crufty thorn in our side for a long time. I'm ready to merge this right now.

Any objections? Going once... going twice...

(I'll give it a couple of hours.)

Ping @laserson @carlyeks @massie

Contributor

tdanford commented Feb 25, 2015

This code has been a crufty thorn in our side for a long time. I'm ready to merge this right now.

Any objections? Going once... going twice...

(I'll give it a couple of hours.)

Ping @laserson @carlyeks @massie

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Feb 26, 2015

Contributor

Alright, here we go.

Contributor

tdanford commented Feb 26, 2015

Alright, here we go.

tdanford added a commit that referenced this pull request Feb 26, 2015

Merge pull request #590 from fnothaft/remove-pileups
[ADAM-589] Removed pileup code.

@tdanford tdanford merged commit cd10066 into bigdatagenomics:master Feb 26, 2015

1 check passed

default Merged build finished.
Details
@pkaleta

This comment has been minimized.

Show comment
Hide comment
@pkaleta

pkaleta Aug 3, 2016

@tdanford I'm trying to follow this tutorial: http://ampcamp.berkeley.edu/5/exercises/genome-analysis-with-adam.html

It's using adamRecords2Pileup method which was removed as part of this. Are there any examples/tutorial of how to achieve a similar functionality?

pkaleta commented Aug 3, 2016

@tdanford I'm trying to follow this tutorial: http://ampcamp.berkeley.edu/5/exercises/genome-analysis-with-adam.html

It's using adamRecords2Pileup method which was removed as part of this. Are there any examples/tutorial of how to achieve a similar functionality?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 3, 2016

Member

Hi @pkaleta! We've eliminated this code a long time back. What sort of computation are you trying to run? If you can give details, then we can point you in the direction of the current "best practice".

Member

fnothaft commented Aug 3, 2016

Hi @pkaleta! We've eliminated this code a long time back. What sort of computation are you trying to run? If you can give details, then we can point you in the direction of the current "best practice".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment