New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-513] Remove ReferenceMappable trait. #592

Merged
merged 1 commit into from Mar 2, 2015

Conversation

Projects
None yet
5 participants
@fnothaft
Member

fnothaft commented Feb 25, 2015

Resolves (?) #513. Removes the ReferenceMappable trait, along with the ReferenceMappingContext. Also strips out the visualization code; @erictu will be moving this into a downstream repository.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Feb 25, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/611/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/611/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Feb 27, 2015

Member

Rebased.

Member

fnothaft commented Feb 27, 2015

Rebased.

@fnothaft fnothaft referenced this pull request Feb 27, 2015

Closed

Adding RegionRDDFunctions #517

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Feb 27, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/613/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/613/
Test PASSed.

@laserson

This comment has been minimized.

Show comment
Hide comment
@laserson

laserson Feb 27, 2015

Contributor

Great work, @fnothaft! I'm happy to merge unless anyone has objections.

Contributor

laserson commented Feb 27, 2015

Great work, @fnothaft! I'm happy to merge unless anyone has objections.

@erictu

This comment has been minimized.

Show comment
Hide comment
@erictu

erictu Mar 1, 2015

Member

@fnothaft, should we strip out the webapp folder in adam-cli/src/main/webapp?

Member

erictu commented Mar 1, 2015

@fnothaft, should we strip out the webapp folder in adam-cli/src/main/webapp?

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Mar 1, 2015

Contributor

I like it too, although I'd (minor quibble) suggest that we could at least drop the VizReads and TrackedLayout stuff as a separate commit (if not a completely separate PR)?

Contributor

tdanford commented Mar 1, 2015

I like it too, although I'd (minor quibble) suggest that we could at least drop the VizReads and TrackedLayout stuff as a separate commit (if not a completely separate PR)?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Mar 1, 2015

Member

@erictu ah, forgot that! Will fix.

@tdanford I'll split that into a separate commit.

Member

fnothaft commented Mar 1, 2015

@erictu ah, forgot that! Will fix.

@tdanford I'll split that into a separate commit.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Mar 2, 2015

Member

Rebased following the #606 merge.

Member

fnothaft commented Mar 2, 2015

Rebased following the #606 merge.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Mar 2, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/622/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/622/
Test PASSed.

laserson added a commit that referenced this pull request Mar 2, 2015

Merge pull request #592 from fnothaft/remove-mapping-context
[ADAM-513] Remove ReferenceMappable trait.

@laserson laserson merged commit 28b34b3 into bigdatagenomics:master Mar 2, 2015

1 check passed

default Merged build finished.
Details
@laserson

This comment has been minimized.

Show comment
Hide comment
@laserson

laserson Mar 2, 2015

Contributor

Thanks, @fnothaft! Happy to see ReferenceMappingContext go :)

Contributor

laserson commented Mar 2, 2015

Thanks, @fnothaft! Happy to see ReferenceMappingContext go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment