New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-605] Remove visualization code. #606

Merged
merged 1 commit into from Mar 2, 2015

Conversation

Projects
None yet
4 participants
@fnothaft
Member

fnothaft commented Mar 2, 2015

Resolves #605. Removes visualization code. @erictu will move this code to a downstream repository. This will clean up #592.

@erictu

This comment has been minimized.

Show comment
Hide comment
@erictu

erictu Mar 2, 2015

Member

Should we remove ReferenceMapping, ReferenceMappingContext, and AlignmentRecordReferenceMappingSuite.scala as well?

Member

erictu commented Mar 2, 2015

Should we remove ReferenceMapping, ReferenceMappingContext, and AlignmentRecordReferenceMappingSuite.scala as well?

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Mar 2, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/621/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/621/
Test PASSed.

@tdanford

This comment has been minimized.

Show comment
Hide comment
@tdanford

tdanford Mar 2, 2015

Contributor

LGTM, I'm going to merge.

@fnothaft @erictu I'd be interested to hear which downstream repository this ends up in, especially the TrackedLayout class.

Contributor

tdanford commented Mar 2, 2015

LGTM, I'm going to merge.

@fnothaft @erictu I'd be interested to hear which downstream repository this ends up in, especially the TrackedLayout class.

tdanford added a commit that referenced this pull request Mar 2, 2015

Merge pull request #606 from fnothaft/remove-viz
[ADAM-605] Remove visualization code.

@tdanford tdanford merged commit 4027323 into bigdatagenomics:master Mar 2, 2015

1 check passed

default Merged build finished.
Details

@fnothaft fnothaft deleted the fnothaft:remove-viz branch Mar 2, 2015

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Mar 2, 2015

Member

Thanks @tdanford. @erictu those other ones will be removed in #592.

Member

fnothaft commented Mar 2, 2015

Thanks @tdanford. @erictu those other ones will be removed in #592.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment