New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make adamLoad public #688

Merged
merged 1 commit into from Jun 2, 2015

Conversation

Projects
None yet
2 participants
@ryan-williams
Member

ryan-williams commented May 31, 2015

fixes #687

Show outdated Hide outdated adam-core/src/main/scala/org/bdgenomics/adam/rdd/ADAMContext.scala
@@ -126,7 +126,7 @@ class ADAMContext(val sc: SparkContext) extends Serializable with Logging {
* @tparam T The type of records to return
* @return An RDD with records of the specified type
*/
private[rdd] def adamLoad[T](filePath: String, predicate: Option[FilterPredicate] = None, projection: Option[Schema] = None)(implicit ev1: T => SpecificRecord, ev2: Manifest[T]): RDD[T] = {
def adamLoad[T](filePath: String, predicate: Option[FilterPredicate] = None, projection: Option[Schema] = None)(implicit ev1: T => SpecificRecord, ev2: Manifest[T]): RDD[T] = {

This comment has been minimized.

@fnothaft

fnothaft May 31, 2015

Member

Howabouts we rename this function from adamLoad to loadParquet?

@fnothaft

fnothaft May 31, 2015

Member

Howabouts we rename this function from adamLoad to loadParquet?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft May 31, 2015

Member

Looks good! I think we made it package private under the assumption that you'd use loadParquet* where * = one of Alignments, Features, etc.

Member

fnothaft commented May 31, 2015

Looks good! I think we made it package private under the assumption that you'd use loadParquet* where * = one of Alignments, Features, etc.

@fnothaft fnothaft closed this May 31, 2015

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft May 31, 2015

Member

Sorry, accidentally closed this!

Member

fnothaft commented May 31, 2015

Sorry, accidentally closed this!

@fnothaft fnothaft reopened this May 31, 2015

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft May 31, 2015

Member

Sorry, accidentally closed this!

Member

fnothaft commented May 31, 2015

Sorry, accidentally closed this!

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams May 31, 2015

Member

@fnothaft any idea what's causing these build failures? The last two failed builds here both had errors like:

2015-05-31 08:09:05 ERROR MetricsSystem:96 - Sink class org.apache.spark.metrics.sink.MetricsServlet cannot be instantialized
java.lang.reflect.InvocationTargetException

This last time it was just scala 2.10 x hadoop 1.0.4, whereas previously it was all 2.10 builds

Member

ryan-williams commented May 31, 2015

@fnothaft any idea what's causing these build failures? The last two failed builds here both had errors like:

2015-05-31 08:09:05 ERROR MetricsSystem:96 - Sink class org.apache.spark.metrics.sink.MetricsServlet cannot be instantialized
java.lang.reflect.InvocationTargetException

This last time it was just scala 2.10 x hadoop 1.0.4, whereas previously it was all 2.10 builds

@fnothaft fnothaft added this to the 0.17.0 milestone Jun 1, 2015

make adamLoad public
  fixes #687

- remove out-of-date @param scaladocs
@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Jun 2, 2015

Member

rebased and squashed

Member

ryan-williams commented Jun 2, 2015

rebased and squashed

fnothaft added a commit that referenced this pull request Jun 2, 2015

@fnothaft fnothaft merged commit 1e54369 into bigdatagenomics:master Jun 2, 2015

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jun 2, 2015

Member

Merged! Thanks @ryan-williams!

Member

fnothaft commented Jun 2, 2015

Merged! Thanks @ryan-williams!

@danvk danvk referenced this pull request Jun 29, 2015

Closed

Update to Adam 0.17 #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment