New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include SequenceRecords from second-in-pair reads #696

Merged
merged 1 commit into from Jun 4, 2015

Conversation

Projects
None yet
3 participants
@ryan-williams
Member

ryan-williams commented Jun 2, 2015

fixes #693

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jun 2, 2015

Member

SGTM! Squash down and I'll merge after tests pass?

Member

fnothaft commented Jun 2, 2015

SGTM! Squash down and I'll merge after tests pass?

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Jun 2, 2015

Member

k, will do. Now that the build has started, can the squash/force-push mess it up? Is that how we end up with some versions succeeding and others failing?

Member

ryan-williams commented Jun 2, 2015

k, will do. Now that the build has started, can the squash/force-push mess it up? Is that how we end up with some versions succeeding and others failing?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jun 2, 2015

Member

Nah, the current build will be unaffected. I wouldn't worry about the squash/force-push issue; it's a transient bug and can be resolved just by rerunning.

Member

fnothaft commented Jun 2, 2015

Nah, the current build will be unaffected. I wouldn't worry about the squash/force-push issue; it's a transient bug and can be resolved just by rerunning.

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Jun 2, 2015

Member

squashed!

Member

ryan-williams commented Jun 2, 2015

squashed!

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jun 3, 2015

Member

Thanks! Can you rebase?

Member

fnothaft commented Jun 3, 2015

Thanks! Can you rebase?

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Jun 3, 2015

Member

rebased!

Member

ryan-williams commented Jun 3, 2015

rebased!

@fnothaft fnothaft added this to the 0.18.0 milestone Jun 3, 2015

@laserson

This comment has been minimized.

Show comment
Hide comment
@laserson

laserson Jun 3, 2015

Contributor

lgtm

Contributor

laserson commented Jun 3, 2015

lgtm

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Jun 4, 2015

Member

bump! I think this is good to go @fnothaft jfyi

Member

ryan-williams commented Jun 4, 2015

bump! I think this is good to go @fnothaft jfyi

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Jun 4, 2015

Member

rebased once more

Member

ryan-williams commented Jun 4, 2015

rebased once more

fnothaft added a commit that referenced this pull request Jun 4, 2015

Merge pull request #696 from ryan-williams/seqrecs
include SequenceRecords from second-in-pair reads

@fnothaft fnothaft merged commit c255256 into bigdatagenomics:master Jun 4, 2015

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jun 4, 2015

Member

Merged! Thanks @ryan-williams!

Member

fnothaft commented Jun 4, 2015

Merged! Thanks @ryan-williams!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment