New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should print a warning message if the user has ADAM_OPTS set. #757

Merged
merged 1 commit into from Aug 11, 2015

Conversation

Projects
None yet
3 participants
@fnothaft
Member

fnothaft commented Aug 7, 2015

Since we removed ADAM_OPTS in #754, we should warn the user if they have ADAM_OPTS set and aren't passing any Spark options otherwise.

Show outdated Hide outdated bin/adam-shell
@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Aug 7, 2015

Member

lgtm, one nit

Member

ryan-williams commented Aug 7, 2015

lgtm, one nit

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams
Member

ryan-williams commented Aug 7, 2015

lgtm

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 7, 2015

Member

Rebased.

Member

fnothaft commented Aug 7, 2015

Rebased.

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Aug 7, 2015

Member

what's the word on merging over a failed build @fnothaft?

Member

ryan-williams commented Aug 7, 2015

what's the word on merging over a failed build @fnothaft?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 7, 2015

Member

The word on merging over a failed build is that I am losing my cool with how the @AmplabJenkins git plugin handles force pushes ;).

Jenkins, test this please.

Member

fnothaft commented Aug 7, 2015

The word on merging over a failed build is that I am losing my cool with how the @AmplabJenkins git plugin handles force pushes ;).

Jenkins, test this please.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 8, 2015

Member

Jenkins, test this please.

Member

fnothaft commented Aug 8, 2015

Jenkins, test this please.

@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Aug 11, 2015

Member

Thanks, Frank!

Member

massie commented Aug 11, 2015

Thanks, Frank!

massie added a commit that referenced this pull request Aug 11, 2015

Merge pull request #757 from fnothaft/warn-adam-opts
We should print a warning message if the user has ADAM_OPTS set.

@massie massie merged commit 0e3b557 into bigdatagenomics:master Aug 11, 2015

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 11, 2015

Member

Can you make sure that pull requests are rebased on master before merging or manually rebase and merge?

Frank Austin Nothaft
fnothaft@alumni.stanford.edu
202-340-0466

On Aug 11, 2015, at 10:44 AM, Matt Massie notifications@github.com wrote:

Merged #757.


Reply to this email directly or view it on GitHub.

Member

fnothaft commented Aug 11, 2015

Can you make sure that pull requests are rebased on master before merging or manually rebase and merge?

Frank Austin Nothaft
fnothaft@alumni.stanford.edu
202-340-0466

On Aug 11, 2015, at 10:44 AM, Matt Massie notifications@github.com wrote:

Merged #757.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment