New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unmapped-read sorting #803

Merged
merged 3 commits into from Aug 24, 2015

Conversation

Projects
None yet
3 participants
@ryan-williams
Member

ryan-williams commented Aug 24, 2015

fixes #799

builds on #802

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/872/
Test PASSed.

AmplabJenkins commented Aug 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/872/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 24, 2015

Member

Should this be merged now or does it need to wait for #800?

Member

heuermh commented Aug 24, 2015

Should this be merged now or does it need to wait for #800?

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Aug 24, 2015

Member

Nah I think this can be merged now, it should go in after #802 though.. doesn't have to, but it has #802 cherry-picked in at the start.

The only difference #800 will make, if we get hadoop-bam upgraded and use that upgrade, is that we'll be able to correctly say SO:coordinate instead of SO:unsorted here.

Member

ryan-williams commented Aug 24, 2015

Nah I think this can be merged now, it should go in after #802 though.. doesn't have to, but it has #802 cherry-picked in at the start.

The only difference #800 will make, if we get hadoop-bam upgraded and use that upgrade, is that we'll be able to correctly say SO:coordinate instead of SO:unsorted here.

heuermh added a commit that referenced this pull request Aug 24, 2015

@heuermh heuermh merged commit 4fd82e6 into bigdatagenomics:master Aug 24, 2015

1 check passed

default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh
Member

heuermh commented Aug 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment