New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-755] updating utils dependency version to 0.2.3, fixes #755 #806

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@heuermh
Member

heuermh commented Aug 24, 2015

No description provided.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/882/
Test PASSed.

AmplabJenkins commented Aug 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/882/
Test PASSed.

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Aug 24, 2015

Member

any known issues with this bump?

Member

ryan-williams commented Aug 24, 2015

any known issues with this bump?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 24, 2015

Member

Jenkins, retest this please

Member

heuermh commented Aug 24, 2015

Jenkins, retest this please

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/883/
Test PASSed.

AmplabJenkins commented Aug 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/883/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 24, 2015

Member

Oops, sorry Jenkins, wrong pull request. :)

Member

heuermh commented Aug 24, 2015

Oops, sorry Jenkins, wrong pull request. :)

@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Aug 27, 2015

Member

Is this ready to merge? I see a question from @ryan-williams that hasn't been addressed. Ryan, is there something in particular that you're concerned about with this bump?

Related: I went to look at the diff on github and noticed that the tag name syntax changed. I'm assuming that's intensional?

screen shot 2015-08-26 at 5 11 17 pm

Member

massie commented Aug 27, 2015

Is this ready to merge? I see a question from @ryan-williams that hasn't been addressed. Ryan, is there something in particular that you're concerned about with this bump?

Related: I went to look at the diff on github and noticed that the tag name syntax changed. I'm assuming that's intensional?

screen shot 2015-08-26 at 5 11 17 pm

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 27, 2015

Member

LGTM.

Related: I went to look at the diff on github and noticed that the tag name syntax changed. I'm assuming that's intensional?

Correct; that is intentional.

Member

fnothaft commented Aug 27, 2015

LGTM.

Related: I went to look at the diff on github and noticed that the tag name syntax changed. I'm assuming that's intensional?

Correct; that is intentional.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 27, 2015

Member

Also, just to respond to @ryan-williams upstream, there are no known issues with utils:0.2.3.

Member

fnothaft commented Aug 27, 2015

Also, just to respond to @ryan-williams upstream, there are no known issues with utils:0.2.3.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 27, 2015

Member

Thanks @heuermh! I've merged this as 5432a61.

Member

fnothaft commented Aug 27, 2015

Thanks @heuermh! I've merged this as 5432a61.

@fnothaft fnothaft closed this Aug 27, 2015

@heuermh heuermh deleted the heuermh:utils-023 branch Aug 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment