New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better validation when saving paired fastqs #830

Merged
merged 1 commit into from Sep 27, 2015

Conversation

Projects
None yet
3 participants
@ryan-williams
Member

ryan-williams commented Sep 24, 2015

  • logError for LENIENT
  • throw for `STRICT
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/926/
Test PASSed.

AmplabJenkins commented Sep 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/926/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 25, 2015

Member

Other than the small nit, LGTM!

Member

fnothaft commented Sep 25, 2015

Other than the small nit, LGTM!

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Sep 25, 2015

Member

nit should be fixed

Member

ryan-williams commented Sep 25, 2015

nit should be fixed

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 25, 2015

Member

Thanks @ryan-williams! I'll leave this open for comments, but if we don't hear from anyone else tomorrow, I'll merge.

Member

fnothaft commented Sep 25, 2015

Thanks @ryan-williams! I'll leave this open for comments, but if we don't hear from anyone else tomorrow, I'll merge.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 25, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/931/
Test PASSed.

AmplabJenkins commented Sep 25, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/931/
Test PASSed.

@fnothaft fnothaft merged commit aea329e into bigdatagenomics:master Sep 27, 2015

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft
Member

fnothaft commented Sep 27, 2015

Thanks @ryan-williams!

@fnothaft fnothaft referenced this pull request Nov 10, 2015

Closed

export valid fastq #856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment