New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-780] Make DecadentRead package private. #845

Merged
merged 1 commit into from Oct 6, 2015

Conversation

Projects
None yet
3 participants
@fnothaft
Member

fnothaft commented Oct 5, 2015

This change changes the DecadentRead class and object from public to package
private (org.bdgenomics.adam). Additionally, we mark both items as deprecated
in favor of the RichAlignmentRecord. Resolves #780.

@fnothaft fnothaft added this to the 0.18.0 milestone Oct 5, 2015

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 5, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/957/
Test PASSed.

AmplabJenkins commented Oct 5, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/957/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 5, 2015

Member

+1

Member

heuermh commented Oct 5, 2015

+1

[ADAM-780] Make DecadentRead package private.
This change changes the DecadentRead class and object from public to package
private (org.bdgenomics.adam). Additionally, we mark both items as deprecated
in favor of the RichAlignmentRecord. Resolves #780.
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 6, 2015

Member

Rebased.

Member

fnothaft commented Oct 6, 2015

Rebased.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 6, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/969/
Test PASSed.

AmplabJenkins commented Oct 6, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/969/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 6, 2015

Member

Thanks!

Member

heuermh commented Oct 6, 2015

Thanks!

heuermh added a commit that referenced this pull request Oct 6, 2015

Merge pull request #845 from fnothaft/private-dr
[ADAM-780] Make DecadentRead package private.

@heuermh heuermh merged commit 9d32233 into bigdatagenomics:master Oct 6, 2015

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment