New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating maven build plugin dependency versions #846

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@heuermh
Member

heuermh commented Oct 5, 2015

No description provided.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 5, 2015

Member

LGTM.

Member

fnothaft commented Oct 5, 2015

LGTM.

@@ -23,7 +23,7 @@
<parquet.version>1.8.1</parquet.version>
<!-- Edit the following line to configure the Hadoop (HDFS) version. -->
<hadoop.version>2.2.0</hadoop.version>
<scoverage.version>0.99.2</scoverage.version>
<scoverage.version>1.1.1</scoverage.version>

This comment has been minimized.

@fnothaft

fnothaft Oct 5, 2015

Member

As an aside, have you checked the output of the coverage profile with this? I don't think the coverage profile works now, would be interesting to see if this fixed it. If not, we should open an issue to tackle later.

@fnothaft

fnothaft Oct 5, 2015

Member

As an aside, have you checked the output of the coverage profile with this? I don't think the coverage profile works now, would be interesting to see if this fixed it. If not, we should open an issue to tackle later.

This comment has been minimized.

@heuermh

heuermh Oct 5, 2015

Member

Will check it out shortly

@heuermh

heuermh Oct 5, 2015

Member

Will check it out shortly

This comment has been minimized.

@heuermh

heuermh Oct 5, 2015

Member

No it does not, let me try with 0.99.10 . . .

@heuermh

heuermh Oct 5, 2015

Member

No it does not, let me try with 0.99.10 . . .

This comment has been minimized.

@heuermh

heuermh Oct 5, 2015

Member

I see as of 0.99.2 support for scala 2.10 was dropped.
https://github.com/scoverage/scalac-scoverage-plugin/blob/master/2.10.md

Updating to 1.1.1 as this pull request does results in a maven transitive dependency error.

Versions 0.99.2 and 0.99.10 fail with
adam-core/target/scoverage.coverage.xml (No such file or directory)

Downgrading to 0.98.2 fails with
adam-core/target/scala-2.10.4/classes/scoverage.coverage (No such file or directory)

@heuermh

heuermh Oct 5, 2015

Member

I see as of 0.99.2 support for scala 2.10 was dropped.
https://github.com/scoverage/scalac-scoverage-plugin/blob/master/2.10.md

Updating to 1.1.1 as this pull request does results in a maven transitive dependency error.

Versions 0.99.2 and 0.99.10 fail with
adam-core/target/scoverage.coverage.xml (No such file or directory)

Downgrading to 0.98.2 fails with
adam-core/target/scala-2.10.4/classes/scoverage.coverage (No such file or directory)

This comment has been minimized.

@fnothaft

fnothaft Oct 6, 2015

Member

I've opened #849 for this.

@fnothaft

fnothaft Oct 6, 2015

Member

I've opened #849 for this.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 5, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/958/
Test PASSed.

AmplabJenkins commented Oct 5, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/958/
Test PASSed.

@ryan-williams

This comment has been minimized.

Show comment
Hide comment
@ryan-williams

ryan-williams Oct 6, 2015

Member

this lgtm, thanks @heuermh. I love the feeling of all of these tools improving under us :)

Member

ryan-williams commented Oct 6, 2015

this lgtm, thanks @heuermh. I love the feeling of all of these tools improving under us :)

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 6, 2015

Member

Thanks @heuermh! Rebased and merged as bbb0c32.

Member

fnothaft commented Oct 6, 2015

Thanks @heuermh! Rebased and merged as bbb0c32.

@fnothaft fnothaft closed this Oct 6, 2015

@heuermh heuermh deleted the heuermh:build-dependency-versions branch Oct 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment