New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-867] add pull requests missing from 0.18.0 release to CHANGES.md #870

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@heuermh
Member

heuermh commented Oct 23, 2015

Fixes #867

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 23, 2015

Member

scripts/changelog.sh overwrites the CHANGES.md file each time. Are you sure you want to edit this manually?

Member

fnothaft commented Oct 23, 2015

scripts/changelog.sh overwrites the CHANGES.md file each time. Are you sure you want to edit this manually?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 23, 2015

Member

No, I don't want to. :)

I was planning to comment out the changelog script call before running the release script for 0.18.1 and editing CHANGES.md manually for the 0.18.1 release, with the idea that the changelog script might be fixed between 0.18.1 and 0.19.0.

Our changelog is kind of strange, in that it says ISSUE [#] but then links to the pull request and then displays the description of the pull request, which may contain the issue number [ADAM-#], which could be but is not a link.

Perhaps for future versions, the changelog might be in the style of

Fixed issues

[ADAM-#] Issue description

Merged pull requests

# [ADAM-#] Pull request description
# Non-issue merged pull request description

Member

heuermh commented Oct 23, 2015

No, I don't want to. :)

I was planning to comment out the changelog script call before running the release script for 0.18.1 and editing CHANGES.md manually for the 0.18.1 release, with the idea that the changelog script might be fixed between 0.18.1 and 0.19.0.

Our changelog is kind of strange, in that it says ISSUE [#] but then links to the pull request and then displays the description of the pull request, which may contain the issue number [ADAM-#], which could be but is not a link.

Perhaps for future versions, the changelog might be in the style of

Fixed issues

[ADAM-#] Issue description

Merged pull requests

# [ADAM-#] Pull request description
# Non-issue merged pull request description

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 23, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/1004/
Test PASSed.

AmplabJenkins commented Oct 23, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/1004/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 26, 2015

Member

Merged as a442ec3.

Member

fnothaft commented Oct 26, 2015

Merged as a442ec3.

@fnothaft fnothaft closed this Oct 26, 2015

@heuermh heuermh deleted the heuermh:changes branch Oct 26, 2015

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 26, 2015

Member

Thanks!

Member

heuermh commented Oct 26, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment