New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P Operator parsing for MDTag #875

Merged
merged 1 commit into from Nov 3, 2015

Conversation

Projects
None yet
4 participants
@arahuja
Contributor

arahuja commented Oct 31, 2015

No description provided.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Oct 31, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/1009/
Test PASSed.

AmplabJenkins commented Oct 31, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/1009/
Test PASSed.

@arahuja arahuja referenced this pull request Oct 31, 2015

Merged

Upgrade to ADAM 0.18 #363

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 1, 2015

Member

LGTM! OOC, how are you getting a P in the middle of a CIGAR? (Or, was that just a unit test case?)

Member

fnothaft commented Nov 1, 2015

LGTM! OOC, how are you getting a P in the middle of a CIGAR? (Or, was that just a unit test case?)

@heuermh heuermh added this to the 0.18.2 milestone Nov 2, 2015

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 2, 2015

Member

We should be able to get a version 0.18.2 release out shortly with this in it, if that helps.

Member

heuermh commented Nov 2, 2015

We should be able to get a version 0.18.2 release out shortly with this in it, if that helps.

@arahuja

This comment has been minimized.

Show comment
Hide comment
@arahuja

arahuja Nov 3, 2015

Contributor

@fnothaft @heuermh Yes, it was just a unit test that had this issue for us - is a P unexpected in the middle of a CIGAR? I did a quick look through a handful of BAMs I had honestly did not find any P's and have run other ADAM utilities without this cropping up, so I'm not sure I've ever seen a CIGAR P in real data.

Contributor

arahuja commented Nov 3, 2015

@fnothaft @heuermh Yes, it was just a unit test that had this issue for us - is a P unexpected in the middle of a CIGAR? I did a quick look through a handful of BAMs I had honestly did not find any P's and have run other ADAM utilities without this cropping up, so I'm not sure I've ever seen a CIGAR P in real data.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 3, 2015

Member

OK! Cool. I was just curious. Let me merge this now...

Member

fnothaft commented Nov 3, 2015

OK! Cool. I was just curious. Let me merge this now...

@fnothaft fnothaft merged commit bc38a1c into bigdatagenomics:master Nov 3, 2015

1 check passed

default Merged build finished.
Details
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 3, 2015

Member

Thanks @arahuja!

Member

fnothaft commented Nov 3, 2015

Thanks @arahuja!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment