New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing symbolic test resource links, read from test classpath instead #927

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@heuermh
Member

heuermh commented Jan 25, 2016

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jan 25, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1070/

Build result: FAILURE

GitHub pull request #927 of commit e35be75 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/927/merge^{commit} # timeout=10 > git branch -a --contains 28b97df659ef197bb80819f27b847b827dc3aef5 # timeout=10 > git rev-parse remotes/origin/pr/927/merge^{commit} # timeout=10Checking out Revision 28b97df659ef197bb80819f27b847b827dc3aef5 (origin/pr/927/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 28b97df659ef197bb80819f27b847b827dc3aef5First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

AmplabJenkins commented Jan 25, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1070/

Build result: FAILURE

GitHub pull request #927 of commit e35be75 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/927/merge^{commit} # timeout=10 > git branch -a --contains 28b97df659ef197bb80819f27b847b827dc3aef5 # timeout=10 > git rev-parse remotes/origin/pr/927/merge^{commit} # timeout=10Checking out Revision 28b97df659ef197bb80819f27b847b827dc3aef5 (origin/pr/927/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 28b97df659ef197bb80819f27b847b827dc3aef5First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 25, 2016

Member

LGTM once build is passing.

Member

fnothaft commented Jan 25, 2016

LGTM once build is passing.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jan 25, 2016

Member

Sorry, I was foiled by classpath caching locally. Thank you, Jenkins.

It appears that ADAMContext.loadBam can't handle classpath jar file paths. Should I just copy the resource to a temporary file first?

Member

heuermh commented Jan 25, 2016

Sorry, I was foiled by classpath caching locally. Thank you, Jenkins.

It appears that ADAMContext.loadBam can't handle classpath jar file paths. Should I just copy the resource to a temporary file first?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 25, 2016

Member

It appears that ADAMContext.loadBam can't handle classpath jar file paths. Should I just copy the resource to a temporary file first?

Ah, yeah, I think I've run into that before... I've done exactly what you're talking about, although that was for a special case. If we'd need to do something hacky like that just to pass unit tests, this approach may not be worth doing, alas... I defer to you. Sorry—I thought this approach would work better...

Member

fnothaft commented Jan 25, 2016

It appears that ADAMContext.loadBam can't handle classpath jar file paths. Should I just copy the resource to a temporary file first?

Ah, yeah, I think I've run into that before... I've done exactly what you're talking about, although that was for a special case. If we'd need to do something hacky like that just to pass unit tests, this approach may not be worth doing, alas... I defer to you. Sorry—I thought this approach would work better...

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jan 25, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1071/
Test PASSed.

AmplabJenkins commented Jan 25, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1071/
Test PASSed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Feb 3, 2016

Member

Thanks @heuermh ! Committed as efe4dfa.

Member

fnothaft commented Feb 3, 2016

Thanks @heuermh ! Committed as efe4dfa.

@fnothaft fnothaft closed this Feb 3, 2016

@heuermh heuermh deleted the heuermh:test-resources branch Feb 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment