New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-934] Properly handle unset library name during duplicate marking #935

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@fnothaft
Member

fnothaft commented Feb 9, 2016

Resolves #934. If the library name for a read group is not set, we will use a null string during the groupBy. This is equivalent to our pre-#906 implementation. Additionally, this commit adds logging that prints a warning message for the user if there are read groups whose library ID is not set.

[ADAM-934] Properly handle unset library name during duplicate marking
Resolves #934. If the library name for a read group is not set, we will use a
null string during the groupBy. This is equivalent to our pre-#906
implementation. Additionally, this commit adds logging that prints a warning
message for the user if there are read groups whose library ID is not set.
@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Feb 9, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1078/
Test PASSed.

AmplabJenkins commented Feb 9, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1078/
Test PASSed.

@jpdna

This comment has been minimized.

Show comment
Hide comment
@jpdna

jpdna Feb 9, 2016

Member

+1

Member

jpdna commented Feb 9, 2016

+1

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Feb 11, 2016

Member

Ping for merge.

Member

fnothaft commented Feb 11, 2016

Ping for merge.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Feb 13, 2016

Member

Fixed via 883ac4d, thanks!

Member

heuermh commented Feb 13, 2016

Fixed via 883ac4d, thanks!

@heuermh heuermh closed this Feb 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment