Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Adam2fastq in case of read with both reverse and unmapped flags #982
referenced this pull request
Mar 26, 2016
I updated PR so that tests cover correctly both umapped with Ox10 set and unset. The existing test did need to be revised as it was incorrect before. I had to add a the new test using different different records because actually the case which was not covered previously was the case of umapped without Ox10 set, and required a different record to test.
I also revised to be consistent what was previously a confusing re-ordering of
is more clear if the tuple order remains the same and the val names are not switched when parsing the tuple.
And yes - I'll squash and rebase