Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out docker/mapping code #34

Closed
fnothaft opened this Issue May 3, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@fnothaft
Copy link
Member

fnothaft commented May 3, 2017

In #25 we add the ability to run BWA through Docker, and to mount reference files locally on the executors. We should factor this code out from BWA into a general pattern that we can use across all of the tools in cannoli.

It should support the matrix of:

  • Running tools natively or running tools from a docker container
  • Mounting index files local to the executor, mounting index files into the docker container, or not doing anything (i.e., index/ref files are on a globally mounted file system)
@heuermh

This comment has been minimized.

Copy link
Member

heuermh commented Oct 27, 2017

@fnothaft is git head the latest you've been using for BWA in cannoli? I need to better grok what is going on with all the path munging so that I can flesh out pull request #54.

@heuermh

This comment has been minimized.

Copy link
Member

heuermh commented Mar 22, 2018

Fixed by #107.

@heuermh heuermh closed this Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.