Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CannoliCommand and CannoliAlignerCommand. #54

Closed
wants to merge 1 commit into from

Conversation

@heuermh
Copy link
Member

@heuermh heuermh commented Jul 5, 2017

Adding CannoliCommand and CannoliAlignerCommand, work in progress towards #34. I get a little shaky with the Scala companion stuff, let me know if this looks like the right approach.

@heuermh heuermh force-pushed the heuermh:cannoli-command branch from ca3ab0a to 185aea3 Jul 5, 2017
@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jul 5, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/42/

Build result: FAILURE

[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/cannoli.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/54/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains 49c7e9e # timeout=10Checking out Revision 49c7e9e (origin/pr/54/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 49c7e9e3ba2367d63a3171e7b6385b7014fd48bdFirst time build. Skipping changelog.Triggering cannoli-prb ? 2.6.0,2.11,1.6.1,centosTriggering cannoli-prb ? 2.3.0,2.11,2.0.0,centosTriggering cannoli-prb ? 2.6.0,2.10,2.0.0,centosTriggering cannoli-prb ? 2.6.0,2.10,1.6.1,centosTriggering cannoli-prb ? 2.3.0,2.10,2.0.0,centosTriggering cannoli-prb ? 2.3.0,2.11,1.6.1,centosTriggering cannoli-prb ? 2.6.0,2.11,2.0.0,centosTriggering cannoli-prb ? 2.3.0,2.10,1.6.1,centoscannoli-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILUREcannoli-prb ? 2.3.0,2.11,2.0.0,centos completed with result FAILUREcannoli-prb ? 2.6.0,2.10,2.0.0,centos completed with result FAILUREcannoli-prb ? 2.6.0,2.10,1.6.1,centos completed with result FAILUREcannoli-prb ? 2.3.0,2.10,2.0.0,centos completed with result FAILUREcannoli-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILUREcannoli-prb ? 2.6.0,2.11,2.0.0,centos completed with result FAILUREcannoli-prb ? 2.3.0,2.10,1.6.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@heuermh heuermh force-pushed the heuermh:cannoli-command branch from 185aea3 to 2fb7fe4 Jul 6, 2017
@coveralls
Copy link

@coveralls coveralls commented Jul 6, 2017

Coverage Status

Coverage decreased (-2.6%) to 32.66% when pulling 2fb7fe4 on heuermh:cannoli-command into 7a098f6 on bigdatagenomics:master.

@AmplabJenkins
Copy link

@AmplabJenkins AmplabJenkins commented Jul 6, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/43/
Test PASSed.

Copy link
Member

@fnothaft fnothaft left a comment

Pretty sure this is just a WIP ;)

optionalExtensions: Seq[String]): Seq[String] = {

// oddly, the hadoop fs apis don't seem to have a way to do this?
def canonicalizePath(fs: FileSystem, path: Path): String = {

This comment has been minimized.

@heuermh

heuermh Oct 27, 2017
Author Member

idk, you wrote that comment :)

}

abstract class CannoliCommand[A <: CannoliArgs] extends BDGSparkCommand[A] with Logging {
// todo: various docker stuff

This comment has been minimized.

@fnothaft

fnothaft Jul 7, 2017
Member

Just flagging this as a TODO.

pathsWithScheme ++ optionalPathsWithScheme
}

// todo: various index stuff

This comment has been minimized.

@fnothaft

fnothaft Jul 7, 2017
Member

Just flagging this as a TODO as well.

@heuermh
Copy link
Member Author

@heuermh heuermh commented Jul 7, 2017

Pretty sure this is just a WIP ;)

Yup, looking for feedback on whether these abstract classes might be the right approach.

@heuermh heuermh modified the milestone: 0.2.0 Jul 26, 2017
@heuermh
Copy link
Member Author

@heuermh heuermh commented Jan 24, 2018

Closing in favor of approach in #69.

@heuermh heuermh closed this Jan 24, 2018
@heuermh heuermh deleted the heuermh:cannoli-command branch Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants