Unlock registers if running linux 4+ #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this was adding a 30 second delay to shutdown.
I use an external RTC for time syncronization, and others may as well. It's better to trust the date command than bbbrtc, especially when a reset here overwrites the now value in the clock.
Moved all logic to a script in /usr/sbin. This will make it easier to call the script manually or support systemd rather than systemv.
The cool kids use systemd, so lets make that nicer.
|
Note, this depends on bbbrtc #2 |
bigjosh
approved these changes
Jan 19, 2019
bigjosh
reviewed
Jan 19, 2019
chkphy
Outdated
|
|
||
| sleep 1 | ||
|
|
||
| # unlock rtc registers if we are running a kernel newer than 3.X | ||
| if [ "$kernel_major" -ge "4" ]; then |
There was a problem hiding this comment.
Just curious: is there any downside to unlocking these if they are already unlocked? If not, could avoid the version check and just always unlock?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check kernel version using uname and call bbbrtc unlock if needed.