New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mjg17/kwalitee use warnings #46

Merged
merged 2 commits into from Apr 30, 2015

Conversation

Projects
None yet
2 participants
@mjg17
Contributor

mjg17 commented Apr 28, 2015

Add 'use warnings' to modules.

Although not all may be required, since some other modules export 'warnings', the Kwalitee tests do not know this. Therefore it's easier to make it explicit in each module.

Note that I've included my Travis patch in this pull request, so that it passes. I'd recommend merging my Travis pull request first, this should then merge cleanly on top. If not, let me know...

Michael Gray added some commits Apr 28, 2015

Michael Gray
Add 'use warnings' to modules.
Although not all may be required, since some other modules export 'warnings', the Kwalitee tests do not know this.
Therefore it's easier to make it explicit in each module.
.

bigpresh added a commit that referenced this pull request Apr 30, 2015

@bigpresh bigpresh merged commit e1881b1 into bigpresh:master Apr 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bigpresh

This comment has been minimized.

Show comment
Hide comment
@bigpresh

bigpresh Apr 30, 2015

Owner

Merged all your pull requests and released 0.40 - many thanks for your contributions, greatly appreciated!

Owner

bigpresh commented Apr 30, 2015

Merged all your pull requests and released 0.40 - many thanks for your contributions, greatly appreciated!

@mjg17

This comment has been minimized.

Show comment
Hide comment
@mjg17

mjg17 Apr 30, 2015

Contributor

That's brilliant, thanks David. It's good to see a new release with my
changes in.

I'll try to do another PR, which isn't needed for inclusion in the actual
release: I wrote a release-testing kwalitee test, using
Test::Kwalitee::Extra. (It's very short, the module does all the work.)

All the best
Michael

On 30 April 2015 at 16:32, David Precious notifications@github.com wrote:

Merged all your pull requests and released 0.40 - many thanks for your
contributions, greatly appreciated!


Reply to this email directly or view it on GitHub
#46 (comment)
.

Contributor

mjg17 commented Apr 30, 2015

That's brilliant, thanks David. It's good to see a new release with my
changes in.

I'll try to do another PR, which isn't needed for inclusion in the actual
release: I wrote a release-testing kwalitee test, using
Test::Kwalitee::Extra. (It's very short, the module does all the work.)

All the best
Michael

On 30 April 2015 at 16:32, David Precious notifications@github.com wrote:

Merged all your pull requests and released 0.40 - many thanks for your
contributions, greatly appreciated!


Reply to this email directly or view it on GitHub
#46 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment